-
Notifications
You must be signed in to change notification settings - Fork 21
Description
I think libmacchina can greatly benefit if we were to lock each readout type
behind its respective feature. e.g.:
- "package" feature for
PackageReadout - "general" feature for
GeneralReadout
I believe this would entice developers that are not willing to ship their
programs with a library that brings a handful of dependencies, and I am one of
them (sort of). As I've been busy working on citron, which uses libmacchina as its
backend, I've had to deal with dependencies that just don't make any sense for
a program like citron.
A change like this could possibly result change like this will result in multiple API breakages, since if we were to truly implement this, it would be in our best interest to modularize libmacchina as much as possible (to avoid breaking the API more and more). An example of this is to create more readout types that have their own set of dependencies, and lower the method count of GeneralReadout type. As it currently has a little too much to offer.
Here's a video of #111 in action:
https://user-images.githubusercontent.com/35816711/147727323-958fb622-cd83-4709-a795-5d5151d952a1.mp4
What are your thoughts?