Tests and comments around rbac and ActsAsArScope

Turns out this is very resilient in the AAAS case
Rbac has already used base_class and where and by the time it gets to the includes/references
It is so far into AR scope land and not even close to the originating class

Author: kbrock

lib/acts_as_ar_model.rb

@@ -158,6 +158,7 @@ def self.search(mode, options = {})
   end
   private_class_method :search
 
+  # Note: ignores references
   def self.to_legacy_options(options)
     {
       :conditions => options[:where],

lib/rbac/filterer.rb

@@ -429,6 +429,8 @@ def select_from_order_columns(columns)
       end
     end
 
+    # For ActsAsArModel - scope should be a a QueryRelation
+    # For ActsAsArScope - scope should be a standard AR scope (with where and others tacked in)
     def include_references(scope, klass, includes, references, exp_includes)
       # TODO: do we want to klass.prune_references(exp_includes)? (see same comment for inline_view? section)
       scope.eager_load(references || {}).eager_load(exp_includes || {}).preload(includes)

spec/lib/rbac/filterer_spec.rb

@@ -2659,11 +2659,32 @@ def get_rbac_results_for_and_expect_objects(klass, expected_objects)
       expect(described_class.filtered(Vm.where(:location => "good"))).to match_array(matched_vms)
     end
 
-    it "support aaarm object" do
+    # Note: VimPerformanceTrend doesn't even implement find. Just testing this follows standard aaarm protocols
+    it "support ActsAsArModel object" do
       expect(VimPerformanceTrend).to receive(:find).with(:all, {:include => {:a => {}}}).and_return([:good])
       expect(described_class.filtered(VimPerformanceTrend, :include_for_find => {:a => {}}).to_a).to match_array([:good])
     end
 
+    it "supports ActsAsArScope object all target" do
+      all_vms
+
+      klass = ManageIQ::Providers::InfraManager::VmOrTemplate
+      expect(klass).to receive(:all).and_call_original
+      expect(described_class.filtered(klass, :include_for_find => {:host => {}}).to_a).to eq(all_vms)
+    end
+
+    it "supports ActsAsArScope object scoping" do
+      all_vms
+      filter = MiqExpression.new("=" => {"field" => "Vm-location", "value" => "good"})
+      expect(described_class.filtered(ManageIQ::Providers::InfraManager::VmOrTemplate, :filter => filter)).to match_array(matched_vms)
+    end
+
+    it "understands ActsAsArScope includes (invalid)" do
+      expect {
+        expect(described_class.filtered(klass, :include_for_find => {:missing_association => {}}).to_a).to eq(klass.none)
+      }.to_raise(ActiveRecord::ConfigurationError)
+    end
+
     # it returns objects too
     # TODO: cap number of queries here
     it "runs rbac on array target" do