From 47f10d2deba9c118d884645eb5a8406299a2d62e Mon Sep 17 00:00:00 2001 From: Brock Hearron Date: Thu, 2 Oct 2025 19:56:22 -0400 Subject: [PATCH 1/2] fix: infinite recursion caused by accessing color of a highlighted Table cell. fix: removed type: ignore[attr-defined] mypy was not a fan of --- manim/mobject/geometry/shape_matchers.py | 8 +------- manim/utils/file_ops.py | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/manim/mobject/geometry/shape_matchers.py b/manim/mobject/geometry/shape_matchers.py index dd696881fa..ddc2916f03 100644 --- a/manim/mobject/geometry/shape_matchers.py +++ b/manim/mobject/geometry/shape_matchers.py @@ -22,7 +22,7 @@ from manim.mobject.mobject import Mobject from manim.mobject.opengl.opengl_mobject import OpenGLMobject from manim.mobject.types.vectorized_mobject import VGroup -from manim.utils.color import BLACK, RED, YELLOW, ManimColor, ParsableManimColor +from manim.utils.color import BLACK, RED, YELLOW, ParsableManimColor class SurroundingRectangle(RoundedRectangle): @@ -151,12 +151,6 @@ def set_style(self, fill_opacity: float, **kwargs: Any) -> Self: # type: ignore ) return self - def get_fill_color(self) -> ManimColor: - # The type of the color property is set to Any using the property decorator - # vectorized_mobject.py#L571 - temp_color: ManimColor = self.color - return temp_color - class Cross(VGroup): """Creates a cross. diff --git a/manim/utils/file_ops.py b/manim/utils/file_ops.py index 5e239be548..c37334a729 100644 --- a/manim/utils/file_ops.py +++ b/manim/utils/file_ops.py @@ -198,7 +198,7 @@ def open_file(file_path: Path, in_browser: bool = False) -> None: if current_os == "Windows": # The method os.startfile is only available in Windows, # ignoring type error caused by this. - os.startfile(file_path if not in_browser else file_path.parent) # type: ignore[attr-defined] + os.startfile(file_path if not in_browser else file_path.parent) else: if current_os == "Linux": commands = ["xdg-open"] From 81379a98b8667b5d13b67312814ca2184d1e89f2 Mon Sep 17 00:00:00 2001 From: Brock Hearron Date: Fri, 3 Oct 2025 08:54:25 -0400 Subject: [PATCH 2/2] fix: added back needed mypy type ignore --- manim/utils/file_ops.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manim/utils/file_ops.py b/manim/utils/file_ops.py index c37334a729..5e239be548 100644 --- a/manim/utils/file_ops.py +++ b/manim/utils/file_ops.py @@ -198,7 +198,7 @@ def open_file(file_path: Path, in_browser: bool = False) -> None: if current_os == "Windows": # The method os.startfile is only available in Windows, # ignoring type error caused by this. - os.startfile(file_path if not in_browser else file_path.parent) + os.startfile(file_path if not in_browser else file_path.parent) # type: ignore[attr-defined] else: if current_os == "Linux": commands = ["xdg-open"]