updated code for improvement and fixes.

Author: Donny Wong

app/controllers/lti_deployments_controller.rb

@@ -183,11 +183,12 @@ def check_host
 
   def create_course
     if LtiConfig.respond_to?(:allowed_to_create_course?) && !LtiConfig.allowed_to_create_course?(record)
+      @title = I18n.t('lti.course_creation_denied')
       @message = format(
         Settings.lti.unpermitted_new_course_message,
         course_name: record.lms_course_name
       )
-      render 'unpermitted_course_creation', status: :unprocessable_entity
+      render 'message', status: :forbidden
       return
     end
 

app/views/lti_deployments/unpermitted_course_creation.html.erb renamed to app/views/lti_deployments/message.html.erb

@@ -1,4 +1,4 @@
 <section id='content'>
-  <h1>Course Creation Not Allowed</h1>
+  <h1><%= @title %></h1>
   <p><%= @message %></p>
 </section>

config/locales/common/en.yml

@@ -22,6 +22,7 @@ en:
   help: Help
   lti:
     config_error: Error configuring LTI.
+    course_creation_denied: Course Creation Not Allowed
     course_exists: A course with this name already exists on MarkUs. Please select a course to link to.
     course_link_error: Unsuccessful. Please relaunch MarkUs from your LMS.
     course_link_success: Success. %{markus_course_name} is now linked with your LMS.

config/settings/development.yml

@@ -42,5 +42,5 @@ lti:
   course_filter_file: <%= "#{::Rails.root}/config/dummy_lti_config.rb" %>
   domains: <%= %w[host.docker.internal] %>
   token_endpoint: "http://host.docker.internal:3100/login/oauth2/token"
-  unpermitted_new_course_message: 'You are not permitted to create a new MarkUs course for %{course_name}. If you are interested to use MarkUs for your course, please contact the MarkUs team at [email protected].'
+  unpermitted_new_course_message: 'You are not permitted to create a new MarkUs course for %{course_name}. Please contact your system administrator.'
   sync_schedule: "0 3 * * *"

spec/controllers/lti_deployments_controller_spec.rb

@@ -151,7 +151,7 @@
 
       it 'responds with an error message' do
         post_as instructor, :create_course, params: course_params
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:forbidden)
       end
     end
   end