Updated view when a course cannot be created via an LTI external tool (#7669)

Author: donny-wong

Changelog.md

@@ -6,6 +6,7 @@
 
 ### ✨ New features and improvements
 - Added new loading spinner icon for tables (#7602)
+- Update message and page displaying cannot create new course via external LTI tool (#7669)
 
 ### 🐛 Bug fixes
 - Resque Host Authorization, removing env condition as this is for all environments (#7671)

app/controllers/lti_deployments_controller.rb

@@ -183,11 +183,12 @@ def check_host
 
   def create_course
     if LtiConfig.respond_to?(:allowed_to_create_course?) && !LtiConfig.allowed_to_create_course?(record)
-      render 'shared/http_status',
-             locals: { code: '422',
-                       message: format(Settings.lti.unpermitted_new_course_message,
-                                       course_name: record.lms_course_name) },
-             status: :unprocessable_entity, layout: false
+      @title = I18n.t('lti.course_creation_denied')
+      @message = format(
+        Settings.lti.unpermitted_new_course_message,
+        course_name: record.lms_course_name
+      )
+      render 'message', status: :forbidden
       return
     end
 

app/views/lti_deployments/message.html.erb

@@ -0,0 +1,4 @@
+<section id='content'>
+  <h1><%= @title %></h1>
+  <p><%= @message %></p>
+</section>

config/locales/common/en.yml

@@ -22,6 +22,7 @@ en:
   help: Help
   lti:
     config_error: Error configuring LTI.
+    course_creation_denied: Course Creation Not Allowed
     course_exists: A course with this name already exists on MarkUs. Please select a course to link to.
     course_link_error: Unsuccessful. Please relaunch MarkUs from your LMS.
     course_link_success: Success. %{markus_course_name} is now linked with your LMS.

spec/controllers/lti_deployments_controller_spec.rb

@@ -151,7 +151,7 @@
 
       it 'responds with an error message' do
         post_as instructor, :create_course, params: course_params
-        expect(response).to have_http_status(:unprocessable_entity)
+        expect(response).to have_http_status(:forbidden)
       end
     end
   end