Skip to content

Distribute NodeJS as part of the wheel #4303

@aaltat

Description

@aaltat

Is your feature request related to a problem? Please describe.
Installing NodeJS dependencies can be problematic with corporate networks and even access to public internet it complicates the installation of the library. Do same as Playwright Python and build NodeJs dependencies as executable and add those in the whl

For NodeJS direction, look https://nodejs.org/api/single-executable-applications.html -> No go, does not work without lots of code changes. The https://github.com/vercel/pkg did not work with latest NodeJS LTS version that have so it is also no go, but the fork https://github.com/yao-pkg/pkg was able to build binary which I was able to run from command line. Lets continue with yao-pkg
For Python side, look https://github.com/pypa/cibuildwheel

  • Migrate to pyproject.tml file, cibuildwheel has better support for it
  • Keep old way of install, just in case
  • Make NodeJS deps as a separate package: BrowserBatteries
  • Redesign package build and publish it must be done by GitHub actions
  • Test should be also run with whl installation.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions