feat(nodeversions): now working for node 10 12 14

Author: MatthD

.gitignore

@@ -192,4 +192,6 @@ $RECYCLE.BIN/
 # Windows shortcuts
 *.lnk
 
-# End of https://www.gitignore.io/api/node,linux,macos,windows,intellij
+# End of https://www.gitignore.io/api/node,linux,macos,windows,intellij
+
+build*

.travis.yml

@@ -6,13 +6,10 @@ os:
 
 env:
   matrix:
-    - NODE_VERSION="10.15"
-    - NODE_VERSION="8.6"
-    - NODE_VERSION="6.11"
-    - NODE_VERSION="4.4"
+    - NODE_VERSION="14.12"
   include:
     - os: osx
-      osx_image: xcode8.3
+      osx_image: xcode12.2
 
 before_install:
 - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew update          ; fi
@@ -31,10 +28,15 @@ before_install:
 - git config --global user.name "MatthD"
 
 install:
-# - npm install --build-from-source
-- npm i nan
+- npm install
+- node-pre-gyp clean
 - node-pre-gyp configure --enable-build-type=release
 - node-pre-gyp build
+- mkdir -p Release/build/4 Release/build/5 Release/build/6 Release/build/7
+- mv build-tmp-napi-v4/Release/xml.node build/4/
+- mv build-tmp-napi-v5/Release/xml.node build/5/
+- mv build-tmp-napi-v6/Release/xml.node build/6/
+- mv build-tmp-napi-v7/Release/xml.node build/7/
 - node-pre-gyp package
 
 script:

Readme.md

@@ -28,7 +28,6 @@ Node-libxml has been thought differently than [libxmljs](https://github.com/libx
 - You want to validate against DTD / schema on multiple documents with just ONE dtd/schema loaded in memory (libxmljs loads it on each validation request), so it's clearly by far fastest!
 
 
-
 ## Install
 
 ```bash
@@ -158,3 +157,13 @@ A function of libxml to free all the memory taken by libxml2
 `TAKE nothing & RETURN nothin`
 free all memory in all instance in all fork using by libxml.
 
+
+## Contribute
+
+### Install
+- `npm i`
+- then move the build-tmp-napi-*{anyversionyougot} as -> `mv build-tmp-napi-v7 build` __(for the moment I did not found how to build directly to buiuld forlder with pre-gyp for n-api)__
+- `npm test` should pass 😎
+
+## Important notes
+Travis & appveyor cannot be used anymore with n-api because auto-publish from node-pre-gyp-github not working anymore + we have now n release for one node version

binding.gyp

@@ -27,6 +27,9 @@
         'MACOSX_DEPLOYMENT_TARGET': '10.7',
         'OTHER_CFLAGS': [ '-Wall' ]
       },
+      'defines': [
+        'NAPI_VERSION=<(napi_build_version)',
+      ],
       'sources': [
         'libxml.cpp',
         'libxml-syntax-error.cpp',

libxml.cpp

@@ -54,31 +54,23 @@ Napi::Value Libxml::loadXml(const Napi::CallbackInfo &info)
     Napi::TypeError::New(env, "loadXml requires at least 1 argument").ThrowAsJavaScriptException();
     return Napi::Boolean::New(env, false);
   }
-  cout << "before libxml" << endl;
   int options;
   options = (XML_PARSE_NOERROR | XML_PARSE_NOWARNING | XML_PARSE_NONET);
-  cout << "after libxml 1" << endl;
   Napi::Array errors = Napi::Array::New(env);
   xmlResetLastError();
   XmlSyntaxError::env = &env;
   xmlSetStructuredErrorFunc(reinterpret_cast<void*>(&errors),
                             XmlSyntaxError::PushToArray);
   if (this->docPtr != nullptr)
   {
-    cout << "after libxml 2" << endl;
     xmlFreeDoc(this->docPtr);
     this->docPtr = nullptr;
   }
-  cout << "after libxml 3" << endl;
   Napi::String path = info[0].As<Napi::String>();
   this->path = path.ToString();
-  cout << "after libxml 4" << endl;
-  cout << this->path.c_str() << endl;
   const char *pathToRead = this->path.c_str();
   this->docPtr = xmlReadFile(pathToRead, NULL, options);
-  cout << "after libxml 5" << endl;
   xmlSetStructuredErrorFunc(NULL, NULL);
-  cout << "after libxml 6" << endl;
   if (this->docPtr == NULL)
   {
     this->Value().Set("wellformedErrors", errors);
@@ -513,4 +505,4 @@ Napi::Object Init(Napi::Env env, Napi::Object exports)
 }
 
 // Register and initialize native add-on
-NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)
+NODE_API_MODULE(NODE_GYP_MODULE_NAME, Init)