Skip to content

Commit 5e01785

Browse files
committed
test: Revise tests and descriptions
1 parent 7b10491 commit 5e01785

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

scripts/yearnBorg.s.sol

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ import {SnapShotExecutor} from "../src/libs/governance/snapShotExecutor.sol";
1717
import {SafeTxHelper} from "../test/libraries/safeTxHelper.sol";
1818
import {IGnosisSafe, GnosisTransaction, IMultiSendCallOnly} from "../test/libraries/safe.t.sol";
1919

20-
contract MockFailSafeImplant {
20+
contract PlaceholderFailSafeImplant {
2121
uint256 public immutable IMPLANT_ID = 0;
2222

23-
error MockFailSafeImplant_UnexpectedTrigger();
23+
error PlaceholderFailSafeImplant_UnexpectedTrigger();
2424

2525
function recoverSafeFunds() external {
26-
revert MockFailSafeImplant_UnexpectedTrigger();
26+
revert PlaceholderFailSafeImplant_UnexpectedTrigger();
2727
}
2828
}
2929

@@ -116,7 +116,7 @@ contract YearnBorgDeployScript is Script {
116116
eject = new ejectImplant(
117117
implantAuth,
118118
address(ychadSafe),
119-
address(new MockFailSafeImplant()), // _failSafe
119+
address(new PlaceholderFailSafeImplant()), // Placeholder because Yearn BORG does not use failSafe
120120
true, // _allowManagement
121121
true // _allowEjection
122122
);

test/yearnBorgAcceptance.t.sol

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,12 @@ contract YearnBorgAcceptanceTest is Test {
159159
assertEq(snapShotExecutor.pendingProposalLimit(), 3, "Unexpected pendingProposalLimit");
160160
}
161161

162+
function testEjectImplantMeta() public {
163+
assertEq(eject.failSafeSignerThreshold(), 0, "Unexpected failSafeSignerThreshold");
164+
assertTrue(eject.ALLOW_AUTH_MANAGEMENT(), "Auth management should be allowed");
165+
assertTrue(eject.ALLOW_AUTH_EJECT(), "Auth ejection should be allowed");
166+
}
167+
162168
/// @dev Safe normal operations should be unrestricted
163169
function testSafeOpUnrestricted() public {
164170
{

0 commit comments

Comments
 (0)