Refactor to allow more thorough testing. Improve test coverage to 100%

Author: jeffsmale90

packages/gator-permissions-controller/src/GatorPermissionsController.test.ts

@@ -13,9 +13,10 @@ import type { HandleSnapRequest, HasSnap } from '@metamask/snaps-controllers';
 import type { SnapId } from '@metamask/snaps-sdk';
 import { hexToBigInt, numberToHex, type Hex } from '@metamask/utils';
 
-import { DELEGATION_FRAMEWORK_VERSION } from './decodePermission';
 import type { GatorPermissionsControllerMessenger } from './GatorPermissionsController';
-import GatorPermissionsController from './GatorPermissionsController';
+import GatorPermissionsController, {
+  DELEGATION_FRAMEWORK_VERSION,
+} from './GatorPermissionsController';
 import {
   mockCustomPermissionStorageEntry,
   mockErc20TokenPeriodicStorageEntry,
@@ -487,6 +488,22 @@ describe('GatorPermissionsController', () => {
       });
     });
 
+    it('throws if contracts are not found', async () => {
+      await expect(
+        controller.decodePermissionFromPermissionContextForOrigin({
+          origin: controller.permissionsProviderSnapId,
+          chainId: 999999,
+          delegation: {
+            caveats: [],
+            delegator: '0x1111111111111111111111111111111111111111',
+            delegate: '0x2222222222222222222222222222222222222222',
+            authority: ROOT_AUTHORITY as Hex,
+          },
+          metadata: buildMetadata(''),
+        }),
+      ).rejects.toThrow('Contracts not found for chainId: 999999');
+    });
+
     it('decodes a native-token-stream permission successfully', async () => {
       const {
         TimestampEnforcer,

packages/gator-permissions-controller/src/GatorPermissionsController.ts

@@ -36,6 +36,7 @@ import {
   deserializeGatorPermissionsMap,
   serializeGatorPermissionsMap,
 } from './utils';
+import { DELEGATOR_CONTRACTS } from '@metamask/delegation-deployments';
 
 // === GENERAL ===
 
@@ -54,6 +55,14 @@ const defaultGatorPermissionsMap: GatorPermissionsMap = {
   other: {},
 };
 
+/**
+ * Delegation framework version used to select the correct deployed enforcer
+ * contract addresses from `@metamask/delegation-deployments`.
+ */
+export const DELEGATION_FRAMEWORK_VERSION = '1.3.0';
+
+const contractsByChainId = DELEGATOR_CONTRACTS[DELEGATION_FRAMEWORK_VERSION];
+
 // === STATE ===
 
 /**
@@ -550,16 +559,22 @@ export default class GatorPermissionsController extends BaseController<
       throw new OriginNotAllowedError({ origin });
     }
 
+    const contracts = contractsByChainId[chainId];
+
+    if (!contracts) {
+      throw new Error(`Contracts not found for chainId: ${chainId}`);
+    }
+
     try {
       const enforcers = caveats.map((caveat) => caveat.enforcer);
 
       const permissionType = identifyPermissionByEnforcers({
         enforcers,
-        chainId,
+        contracts,
       });
 
       const { expiry, data } = getPermissionDataAndExpiry({
-        chainId,
+        contracts,
         caveats,
         permissionType,
       });