Skip to content

Commit bb3e75e

Browse files
sophieqguVGR-GIT
andauthored
chore: switch to mobile optin endpoint (#20554)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Migrates opt-in to a mobile timestamp-signed flow (EVM and Solana), adds InvalidTimestamp retry, and updates service endpoints, types, messenger, and tests. > > - **Rewards opt-in flow**: > - Replace challenge-based `optin` with timestamp-signed mobile flow in `RewardsController` using `#signRewardsMessage` and `RewardsDataService:mobileOptin`. > - Add retry on `InvalidTimestampError` and support both EVM and Solana signing paths. > - **Data service**: > - Add `mobileOptin(body)` calling `/auth/mobile-optin`; remove `generateChallenge`/`optin` usage for controller path. > - Return `InvalidTimestampError` with server timestamp; log error payloads. > - **Types**: > - Remove `GenerateChallengeDto`, `ChallengeResponseDto`, `LoginDto`; add `MobileOptinDto` and refine `MobileLoginDto`. > - **Messenger**: > - Replace allowed actions `generateChallenge`/`optin` with `mobileOptin`. > - **Tests**: > - Update controller and service tests for mobile opt-in (EVM/Solana), timestamp retry, and token storage handling. > - Minor fix: cast `base58.decode` Buffer to `Uint8Array` in tests. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 5b9aa5c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Rik Van Gulck <[email protected]>
1 parent c4683c5 commit bb3e75e

File tree

7 files changed

+412
-223
lines changed

7 files changed

+412
-223
lines changed

0 commit comments

Comments
 (0)