When invoking Snaps directly, e.g. from within MetaMask, we were currently not validating that Snaps were installed. This means that misleading errors would be thrown about permissions when the Snap was not installed in the first place. Also removes this check from one RPC method, since it is now unnecessary. We leave the RPC method around in `invokeKeyring` to not change the error handling behavior. Closes #3658  --- > [!NOTE] > Adds an installation check to SnapController.handleRequest, removes redundant snap-installed checks from invokeSnap, aligns error messages, and updates tests and coverage thresholds. > > - **SnapController**: > - Validate Snap exists in `handleRequest` and throw a clear error if not installed. > - Refactor subsequent checks to use local `snap` (enabled/status). > - **RPC Methods**: > - `invokeSnap`: Remove `getSnap` hook and installed check; rely on controller for validation. > - `invokeKeyring`: Align "not installed" error message with controller. > - **Tests**: > - Add test for non-installed Snap in `SnapController.handleRequest`. > - Update `invokeSnap` tests to drop `getSnap` usage and non-installed error case. > - Update `invokeKeyring` tests to match new error message. > - **Config**: > - Slightly adjust Jest coverage thresholds in `snaps-rpc-methods`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 303b2b9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup>

Validate that Snap is installed in handleRequest #3658

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions