-
Notifications
You must be signed in to change notification settings - Fork 12
Fix broken reference links and grammer updates #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is geared toward making the content more readable by providing space between busy objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed a "space" added to make it render properly as a list.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no file named veda-jh-access.html so I linked it with "Getting access"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammatical error
| ``` | ||
|
|
||
| **summaries example for periodic collection** | ||
| **summaries example for non-periodic collection** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples were incorrectly labelled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why delta-ui was included, but changed all to veda-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken reference link
stephenkilbourn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion, but this looks great
Co-authored-by: Stephen Kilbourn <[email protected]>
Summary
There were several instances of old links that resolved to no webpage or reference links which weren't pointing to the correct document page -- these have been updated. Additionally there was a single grammatical error. Finally, there were references to
delta-uiwhich should likely be phrased asveda-ui.