-
Notifications
You must be signed in to change notification settings - Fork 14
Deprecation of CopyCorners
#240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to mention - if not assert or try/catch in the model - that those are halo=3 tuned. Previous code was as well and that wasn't really said
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I have two questions:
- Is
stencils/still the right folder now that corners aren't stencils anymore? - Is there any way we can do (simple) tests here in NDSL to ensure corners work correctly?
|
Let's move this inside |
CopyCorners
Description
After a deep-dive into how our model performs on CPU it became apparent that the CopyCorners codes were underperforming by a large margin. The implementation of those is happening in PyFV3 and therefore the
CopyCorernscalls are being deprecated here.How has this been tested?
Ran orchestrated & non-orchestrated regression tests (CopyCorners / FvTp2d and Del6VtFlux)
Checklist