Skip to content

Conversation

@twicki
Copy link
Collaborator

@twicki twicki commented Sep 24, 2025

Description

After a deep-dive into how our model performs on CPU it became apparent that the CopyCorners codes were underperforming by a large margin. The implementation of those is happening in PyFV3 and therefore the CopyCorerns calls are being deprecated here.

How has this been tested?

Ran orchestrated & non-orchestrated regression tests (CopyCorners / FvTp2d and Del6VtFlux)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

Copy link
Collaborator

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to mention - if not assert or try/catch in the model - that those are halo=3 tuned. Previous code was as well and that wasn't really said

@twicki twicki mentioned this pull request Sep 24, 2025
8 tasks
Copy link
Collaborator

@romanc romanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have two questions:

  1. Is stencils/ still the right folder now that corners aren't stencils anymore?
  2. Is there any way we can do (simple) tests here in NDSL to ensure corners work correctly?

@FlorianDeconinck
Copy link
Collaborator

Let's move this inside pyFV3 and deal with it in NOAA-GFDL/PyFV3#87

@twicki twicki changed the title Implementation of plain-numpy corners Deprecation of CopyCorners Oct 7, 2025
@romanc romanc mentioned this pull request Oct 8, 2025
7 tasks
@romanc romanc added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NOAA-GFDL:develop with commit 7fef2f5 Oct 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants