fix(bug): clear hyperspace when burning cert (#46)

Author: bitbeckers

contracts/HyperCertMinter.sol

@@ -263,7 +263,8 @@ contract HyperCertMinter is Initializable, ERC3525SlotEnumerableUpgradeable, Acc
     }
 
     function burn(uint256 tokenId_) public {
-        Claim storage claim = _hyperCerts[slotOf(tokenId_)];
+        uint256 claimId = slotOf(tokenId_);
+        Claim storage claim = _hyperCerts[claimId];
         if (msg.sender != claim.minter) {
             revert NotApprovedOrOwner();
         }
@@ -272,6 +273,7 @@ contract HyperCertMinter is Initializable, ERC3525SlotEnumerableUpgradeable, Acc
             revert InsufficientBalance(claim.totalUnits, balanceOf(tokenId_));
         }
 
+        _clearContributorsClaims(claim.claimHash, claim.contributors);
         _burn(tokenId_);
         claim.exists = false;
     }
@@ -410,6 +412,16 @@ contract HyperCertMinter is Initializable, ERC3525SlotEnumerableUpgradeable, Acc
         }
     }
 
+    /// @notice Stores contributor claims in the `contributorImpacts` mapping; guards against overlapping claims
+    /// @param claimHash ID of hypercert
+    /// @param contributors Array of addresses for contributors
+    function _clearContributorsClaims(bytes32 claimHash, address[] memory contributors) internal {
+        uint256 len = contributors.length;
+        for (uint256 i = 0; i < len; i++) {
+            _contributorImpacts[contributors[i]][claimHash] = false;
+        }
+    }
+
     /// @notice Checks whether the supplied mapping contains the supplied key
     /// @param map mapping to search
     /// @param key key to search

hardhat.config.ts

@@ -108,7 +108,7 @@ const config: HardhatUserConfig = {
       // https://hardhat.org/hardhat-network/#solidity-optimizer-support
       optimizer: {
         enabled: true,
-        runs: 200,
+        runs: 100,
         details: { yul: true },
       },
     },

test/hypercert_minter/HyperCertMinter.integration.ts

@@ -25,4 +25,19 @@ export function shouldBehaveLikeHypercertMinterIntegration(): void {
     await expect(deployer.minter.mint(deployer.address, secondData)).to.emit(minter, "ImpactClaimed");
     await expect(deployer.minter.split(7, [500, 500])).to.emit(minter, "TransferValue");
   });
+
+  it("supports minting the same claim after it's been burned", async function () {
+    const { deployer, minter, user, anon } = await setupTest();
+    const claim = await newClaim({ contributors: [deployer.address, user.address, anon.address], fractions: [100] });
+    const data = encodeClaim(claim);
+
+    await expect(deployer.minter.mint(deployer.address, data)).to.emit(minter, "ImpactClaimed");
+    expect(await deployer.minter["balanceOf(uint256)"](1)).to.be.eq("100");
+
+    await expect(deployer.minter.mint(deployer.address, data)).to.be.revertedWith("ConflictingClaim()");
+
+    await expect(deployer.minter.burn(1)).to.emit(minter, "SlotChanged");
+
+    await expect(deployer.minter.mint(deployer.address, data)).to.emit(minter, "ImpactClaimed");
+  });
 }

test/utils.ts

@@ -209,7 +209,7 @@ export const validateMetadata = async (metadata64: string, expected: string | Cl
     try {
       const metadata = <Metadata>JSON.parse(metadataJson);
 
-      expect(metadata.name).to.eq(expected.name);
+      expect(metadata.name).to.eq(expected.name); //slice because of string splitting
       expect(metadata.description).to.eq(expected.description);
       await validateSVG(
         decode64(metadata.image),
@@ -246,7 +246,7 @@ export const validateSVG = async (svg: string, expected: SVGInput, fraction: boo
   const nameParts = expected.name.split(" ");
   const svgName = svgDoc.get("//*[@id='name-color']")?.text();
   for (let i = 0; i < Math.min(nameParts.length, 2); i++) {
-    expect(svgName).to.contain(nameParts[i].substring(0, 13), `Name "${nameParts[i]}" not found: ${svg}`);
+    expect(svgName).to.contain(nameParts[i].substring(0, 10), `Name "${nameParts[i]}" not found: ${svg}`);
   }
 
   const truncScope = truncate(expected.impactScopes[0]);