Merge pull request #31 from NikolayS/prepare_v2

Extensions report, "wide" removed, fix /0 error, more

Author: NikolayS

.gitignore

@@ -0,0 +1,2 @@
+.DS_Store
+

init/generate.sh

@@ -5,8 +5,8 @@ DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 WARMUP="warmup.psql"
 OUT="start.psql"
 
-echo "" > "$WARMUP"
-echo "" > "$OUT"
+> "$WARMUP"
+> "$OUT"
 
 cd "$DIR/.."
 cat > "$WARMUP" <<- VersCheck
@@ -47,11 +47,6 @@ do
   desc=$(head -n1 $f | sed -e 's/^--//g')
   printf "%s '%4s – %s'\n" "\\echo" "$prefix" "$desc" >> "$OUT"
 done
-echo "\\if :postgres_dba_wide" >> "$OUT"
-  printf "  %s '%4s – %s'\n" "\\echo" "x" "Turn Wide Mode OFF (currently ON): show less details, less columns" >> "$OUT"
-echo "\\else" >> "$OUT"
-  printf "  %s '%4s – %s'\n" "\\echo" "x" "Turn Wide Mode ON (currently OFF): show more details, more columns" >> "$OUT"
-echo "\\endif" >> "$OUT"
 printf "%s '%4s – %s'\n" "\\echo" "q" "Quit" >> "$OUT"
 echo "\\echo" >> "$OUT"
 echo "\\echo Type your choice and press <Enter>:" >> "$OUT"
@@ -64,23 +59,11 @@ do
   prefix=$(echo $f | sed -e 's/_.*$//g' -e 's/^.*\///g')
   echo ":d_stp::text = '$prefix' as d_step_is_$prefix," >> "$OUT"
 done
-echo ":d_stp::text = 'x' as d_step_is_x," >> "$OUT"
 echo ":d_stp::text = 'q' as d_step_is_q \\gset" >> "$OUT"
 
 echo "\\if :d_step_is_q" >> "$OUT"
 echo "  \\echo 'Bye!'" >> "$OUT"
 echo "  \\echo" >> "$OUT"
-echo "\\elif :d_step_is_x" >> "$OUT"
-  echo "\\if :postgres_dba_wide" >> "$OUT"
-    echo "set postgres_dba.wide = 'off';" >> "$OUT"
-    echo "  \\echo 'Wide mode turned OFF!'" >> "$OUT"
-    echo "  \\echo" >> "$OUT"
-  echo "\\else" >> "$OUT"
-    echo "set postgres_dba.wide = 'on';" >> "$OUT"
-    echo "  \\echo 'Wide mode turned ON!'" >> "$OUT"
-    echo "  \\echo" >> "$OUT"
-  echo "\\endif" >> "$OUT"
-  echo "  \\ir ./$OUT" >> "$OUT"
 for f in ./sql/*.sql
 do
   prefix=$(echo $f | sed -e 's/_.*$//g' -e 's/^.*\///g')

sql/0_node.sql

@@ -1,11 +1,24 @@
 --Node & Current DB Information: master/replica, lag, DB size, tmp files, etc
+
+/*
+For Postgres versions older than 10, run this first:
+
+  \set postgres_dba_last_wal_receive_lsn pg_last_xlog_receive_location
+  \set postgres_dba_last_wal_replay_lsn pg_last_xlog_replay_location
+  \set postgres_dba_is_wal_replay_paused pg_is_xlog_replay_paused
+*/
+
 with data as (
   select s.*
   from pg_stat_database s
   where s.datname = current_database()
 )
 select 'Postgres Version' as metric, version() as value
 union all
+select
+  'Config file' as metric,
+  (select setting from pg_settings where name = 'config_file') as value
+union all
 select
   'Role' as metric,
   case
@@ -35,17 +48,34 @@ select 'Started At', pg_postmaster_start_time()::timestamptz(0)::text
 union all
 select 'Uptime', (now() - pg_postmaster_start_time())::interval(0)::text
 union all
-select 'Checkpoints', (select (checkpoints_timed + checkpoints_req)::text from pg_stat_bgwriter)
+select
+  'Checkpoints',
+  (select (checkpoints_timed + checkpoints_req)::text from pg_stat_bgwriter)
 union all
-select 'Forced Checkpoints', (select round(100.0 * checkpoints_req::numeric / (checkpoints_timed + checkpoints_req), 1)::text || '%' from pg_stat_bgwriter)
+select
+  'Forced Checkpoints',
+  (
+    select round(100.0 * checkpoints_req::numeric /
+      (nullif(checkpoints_timed + checkpoints_req, 0)), 1)::text || '%'
+    from pg_stat_bgwriter
+  )
 union all
-select 'Checkpoint MB/sec', (select round((buffers_checkpoint::numeric / ((1024.0 * 1024 / (current_setting('block_size')::numeric))  * extract('epoch' from now() - stats_reset)))::numeric, 6)::text from pg_stat_bgwriter)
+select
+  'Checkpoint MB/sec',
+  (
+    select round((nullif(buffers_checkpoint::numeric, 0) /
+      ((1024.0 * 1024 /
+        (current_setting('block_size')::numeric))
+          * extract('epoch' from now() - stats_reset)
+      ))::numeric, 6)::text
+    from pg_stat_bgwriter
+  )
 union all
 select repeat('-', 33), repeat('-', 88)
 union all
 select 'Database Name' as metric, datname as value from data
 union all
-select 'Database Size', pg_catalog.pg_size_pretty(pg_catalog.pg_database_size(current_database()))
+select 'Database Size', pg_size_pretty(pg_database_size(current_database()))
 union all
 select 'Stats Since', stats_reset::timestamptz(0)::text from data
 union all
@@ -70,5 +100,7 @@ select 'Temp Files: total size', pg_size_pretty(temp_bytes)::text from data
 union all
 select 'Temp Files: total number of files', temp_files::text from data
 union all
+select 'Temp Files: avg file size', pg_size_pretty(temp_bytes::numeric / nullif(temp_files, 0))::text from data
+union all
 select 'Deadlocks', deadlocks::text from data
 ;

sql/1_databases.sql

@@ -81,9 +81,5 @@ select
   conflicts as "Conflicts",
   deadlocks as "Deadlocks",
   temp_files::text || coalesce(' (' || pg_size_pretty(temp_bytes) || ')', '') as "Temp. Files"
-\if :postgres_dba_wide
-  ,
-  *
-\endif
 from data2
 order by oid is null desc, size desc nulls last;

sql/2_table_sizes.sql

@@ -70,18 +70,6 @@ select
     100 * toast_bytes::numeric / nullif(sum(toast_bytes) over (partition by (schema_name is null), left(table_name, 3) = '***'), 0),
     2
   )::text || '%)' as "TOAST Size"
-\if :postgres_dba_wide
-  ,
-  row_estimate,
-  total_bytes,
-  table_bytes,
-  index_bytes,
-  toast_bytes,
-  schema_name,
-  table_name,
-  tblspace,
-  oid
-\endif
 from data2
 where schema_name is distinct from 'information_schema'
 order by oid is null desc, total_bytes desc nulls last;

sql/b1_table_estimation.sql

@@ -76,14 +76,6 @@ select
     || case greatest(last_autovacuum, last_vacuum)
       when last_autovacuum then ' (auto)'
     else '' end as "Last Vaccuum"
-\if :postgres_dba_wide
-  ,
-  fillfactor,
-  real_size as real_size_raw,
-  extra_size as extra_size_raw,
-  bloat_size as bloat_size_raw,
-  real_size - bloat_size as live_data_size_raw
-\endif
 from step4
 order by real_size desc nulls last
 ;

sql/b2_btree_estimation.sql

@@ -105,16 +105,6 @@ select
   '~' || pg_size_pretty(bloat_size::numeric)::text || ' (' || round(bloat_ratio::numeric, 2)::text || '%)' as "Bloat",
   '~' || pg_size_pretty((real_size - bloat_size)::numeric) as "Live",
   fillfactor
-\if :postgres_dba_wide
-  ,
-  schema_name,
-  table_name,
-  index_name,
-  real_size as real_size_raw,
-  extra_size as extra_size_raw,
-  bloat_size as bloat_size_raw,
-  real_size - bloat_size as live_data_size_raw
-\endif
 from step4
 order by real_size desc nulls last
 ;

sql/e1_extensions.sql

@@ -0,0 +1,11 @@
+--List of extensions installed in the current DB
+
+select
+  ae.name,
+  installed_version,
+  default_version,
+  extversion as available_version,
+  case when installed_version <> extversion then 'OLD' end as actuality
+from pg_extension e
+join pg_available_extensions ae on extname = ae.name
+order by ae.name;

sql/i2_redundant_indexes.sql

@@ -8,11 +8,11 @@
 -- `CREATE INDEX`, put them to revert/rollback migration script.
 
 -- It is also a good idea to manually double check all indexes being dropped.
--- WARNING here: when you are dropping an index B which is redundant to some index A, 
+-- WARNING here: when you are dropping an index B which is redundant to some index A,
 -- check that you don't drop the A itself at the same time (it can be in "unused").
 -- So if B is "redundant" to A and A is "unused", the script will suggest
 -- dropping both. If so, it is probably better to drop B and leave A.
--- -- in this case there is a chance that A will be used. If it will still be unused, 
+-- -- in this case there is a chance that A will be used. If it will still be unused,
 -- you will drop it during the next cleanup routine procedure.
 
 -- This query doesn't need any additional extensions to be installed
@@ -22,7 +22,7 @@
 -- It also does't do anything except reading system catalogs and
 -- printing NOTICEs, so you can easily run it on your
 --  production *master* database.
--- (Keep in mind, that on replicas, the whole picture of index usage 
+-- (Keep in mind, that on replicas, the whole picture of index usage
 -- is usually very different from master).
 
 -- TODO: take into account type of index and opclass
@@ -66,9 +66,9 @@ with unused as (
     join index_data as i2 on i1.indrelid = i2.indrelid and i1.indexrelid <> i2.indexrelid
   where
     (regexp_replace(i1.indpred, 'location \d+', 'location', 'g') IS NOT DISTINCT FROM regexp_replace(i2.indpred, 'location \d+', 'location', 'g'))
-    and (regexp_replace(i1.indexprs, 'location \d+', 'location', 'g') IS NOT DISTINCT FROM regexp_replace(i2.indexprs, 'location \d+', 'location', 'g')) 
+    and (regexp_replace(i1.indexprs, 'location \d+', 'location', 'g') IS NOT DISTINCT FROM regexp_replace(i2.indexprs, 'location \d+', 'location', 'g'))
     and ((i1.nkeys > i2.nkeys and not i2.indisunique) OR (i1.nkeys=i2.nkeys and ((i1.indisunique and i2.indisunique and (i1.indexrelid>i2.indexrelid)) or (not i1.indisunique and not i2.indisunique and (i1.indexrelid>i2.indexrelid)) or (i1.indisunique and not i2.indisunique))))
-    and i1.key_array[1:i2.nkeys]=i2.key_array 
+    and i1.key_array[1:i2.nkeys]=i2.key_array
 ), together as (
   select reason, tablename, indexname, size, indexdef, null as main_indexdef, indexrelid
   from unused
@@ -77,17 +77,22 @@ with unused as (
   from redundant
   order by tablename asc, indexname
 ), droplines as (
-  select format('DROP INDEX %s; -- %s, %s, table %s', max(indexname), max(size), string_agg(reason, ', '), tablename) as line
+  select format('DROP INDEX CONCURRENTLY %s; -- %s, %s, table %s', max(indexname), max(size), string_agg(reason, ', '), tablename) as line
   from together t1
   group by tablename, indexrelid
   order by tablename, indexrelid
 ), createlines as (
- select format('%s; -- table %s', max(indexdef), tablename) as line
+  select
+    replace(
+      format('%s; -- table %s', max(indexdef), tablename),
+      'CREATE INDEX',
+      'CREATE INDEX CONCURRENTLY'
+    )as line
   from together t2
   group by tablename, indexrelid
   order by tablename, indexrelid
 )
-select '-- Do migration: --' as out
+select '-- Do migration: --' as run_in_separate_transactions
 union all
 select * from droplines
 union all

sql/p1_alignment_padding.sql

@@ -192,11 +192,6 @@ select
     else null
   end as "Suggested Columns Reorder"
   --case when padding_total_est > 0 then array_to_string(alt_cols, ', ') else null end as "Suggested Columns Reorder"
-\if :postgres_dba_wide
-  ,
-  padding_sum as "Bytes Wasted in a Row",
-  *
-\endif
 from result r1
 order by table_bytes desc
 ;