Merge pull request #110 from NuiCpp/fix/dangling-attribute-function

5cript · web-flow · commit 0501f2263efc · 2024-06-12T23:33:54.000+02:00
Fixed dangling reference to function.
diff --git a/nui/include/nui/frontend/attributes/reference.hpp b/nui/include/nui/frontend/attributes/reference.hpp
@@ -19,7 +19,7 @@ namespace Nui::Attributes
         requires std::invocable<T, Nui::val&&>
         Attribute onMaterialize(T&& func) const
         {
-            return operator=([&func](std::weak_ptr<Dom::BasicElement>&& element) {
+            return operator=([func = std::forward<T>(func)](std::weak_ptr<Dom::BasicElement>&& element) {
                 func(element.lock()->val());
             });
         }

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ namespace Nui::Attributes`
`19`	`19`	`requires std::invocable<T, Nui::val&&>`
`20`	`20`	`Attribute onMaterialize(T&& func) const`
`21`	`21`	`{`
`22`		`- return operator=([&func](std::weak_ptr<Dom::BasicElement>&& element) {`
	`22`	`+ return operator=([func = std::forward<T>(func)](std::weak_ptr<Dom::BasicElement>&& element) {`
`23`	`23`	`func(element.lock()->val());`
`24`	`24`	`});`
`25`	`25`	`}`