Skip to content

Commit 0f9a6a3

Browse files
diaztulaJamesAPetts
authored andcommitted
fix: 🐛 cross product to compute Z direction in getImageData (#59)
* The cross method from cornerstone-math modifies the calling object. Update code to correctly use this function.
1 parent 2f86a99 commit 0f9a6a3

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/lib/getImageData.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,12 @@ export default function getImageData(imageIds, displaySetInstanceUid) {
2323
columnCosines[1],
2424
columnCosines[2]
2525
);
26-
const crossProduct = colCosineVec.cross(rowCosineVec);
26+
27+
const crossProduct = new Vector3(
28+
rowCosines[0],
29+
rowCosines[1],
30+
rowCosines[2]
31+
).cross(colCosineVec);
2732

2833
const orientation = determineOrientation(crossProduct);
2934
const zAxis = computeZAxis(orientation, metaDataMap);

0 commit comments

Comments
 (0)