Enable DUNE grid tests #903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoilRos
added
the
manual:irrelevant
|
jenkins build this serial please |
For this to work it is additionally needed that * Entities return the correct number of faces (to count intersections in the tests) * The refinement does not throw. Instead, it returns false when it cannot make a refinement. * DUNE is at least version 2.10 due to https://gitlab.dune-project.org/core/dune-grid/-/merge_requests/734
SoilRos
force-pushed
the
feature/enable-dune-grid-tests
branch
from
29fc137 to
36a7c00
Compare
|
jenkins build this serial please |
|
The CI does not seem to have DUNE 2.10, hence, this cannot be tested there. For now, I only can assure that this works locally, but it would be nice to have an automated test so that we can see if the test from DUNE are broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to work it is additionally needed that
Footnotes
"Correct" here means with respect to the topology of a cube which is what the number of corners says. This is not correct for deformed entities though. Hence, this goes from wrong-wrong, to simply wrong. ↩