Lmod spider modules impl #12
Conversation
|
|
||
| script: | ||
| native: | ||
| - "--ntasks=1" |
There was a problem hiding this comment.
This doesn't have any affect on the localhost adapter.
| # Write connection.yml so OOD can display the session | ||
| ( | ||
| umask 077 | ||
| cat > connection.yml << EOL | ||
| --- | ||
| host: "${host}" | ||
| port: "${port}" | ||
| password: "${password}" | ||
| EOL | ||
| ) |
There was a problem hiding this comment.
This should be done automatically by our wrapper scripts. Did it not work for you automatically?
|
|
||
| if [ -f /usr/share/lmod/lmod/init/bash ]; then | ||
| source /usr/share/lmod/lmod/init/bash | ||
| fi | ||
|
|
||
| module purge | ||
| module use /opt/modulefiles |
There was a problem hiding this comment.
I think instead of the source and module use commands, we probably need to add something to /etc/profile.d from lmod.
| batch_connect: | ||
| basic: | ||
| module_file_dir: "/etc/ood/config/modules" |
There was a problem hiding this comment.
This does not have any affect.
There was a problem hiding this comment.
Try not to add unnecessary file modifications like the ones in this file.
| RUN bash -lc 'module use /opt/modulefiles && \ | ||
| tmp=$(mktemp) && \ | ||
| $LMOD_DIR/spider -o spider-json "$MODULEPATH" > "$tmp" && \ | ||
| mkdir -p /etc/ood/config/modules && \ | ||
| mv "$tmp" /etc/ood/config/modules/localhost.json && \ | ||
| chmod 644 /etc/ood/config/modules/localhost.json && \ | ||
| chmod 755 /etc/ood/config/modules' |
There was a problem hiding this comment.
Why not just write directly into /etc/ood/config/modules/localhost.json?
|
I got too excited to submit my first pr that I left a lot of dangling experiments and fiddling. Like the mktemp which was originally written to not clutter up my desktops working dir when I downloaded lmod on my machine. Or after.sh.erb etc. Ill clean this up today. |
OK, cool. |
2 participants
This implements issue #3
I also restructured our Dockerfile to cache a little better while I was in the process of learning pip wheels/lmod.