Skip to content

Commit 808869b

Browse files
ishanBahugunakasya
authored andcommitted
fix(ui): improve mobile navigation menu in Header.tsx (#2217)
* fix(ui): fixed usermenu styling on mobile screens * fixed syntax issue * Update styling --------- Co-authored-by: Kate <[email protected]>
1 parent ce57128 commit 808869b

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

frontend/src/components/Header.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,11 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
133133
<div className="md:hidden">
134134
<Button
135135
onPress={toggleMobileMenu}
136-
className="bg-transparent text-slate-300 hover:bg-transparent hover:text-slate-100 focus:outline-hidden"
136+
className="flex h-11 w-11 items-center justify-center bg-transparent text-slate-300 hover:bg-transparent hover:text-slate-100 focus:outline-hidden"
137137
>
138138
<span className="sr-only">Open main menu</span>
139139
{mobileMenuOpen ? (
140-
<FontAwesomeIcon icon={faTimes} className="h-6 w-6" />
140+
<FontAwesomeIcon icon={faTimes} size="2x" />
141141
) : (
142142
<FontAwesomeIcon icon={faBars} className="h-6 w-6" />
143143
)}
@@ -153,7 +153,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
153153
>
154154
<div className="flex h-full flex-col justify-between gap-1 px-2 pt-2 pb-3">
155155
{/* Logo */}
156-
<div className="flex flex-col justify-center gap-1">
156+
<div className="flex flex-col justify-center gap-5">
157157
<Link href="/" onClick={() => setMobileMenuOpen(false)}>
158158
<div className="flex h-full items-center">
159159
<Image
@@ -186,8 +186,8 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
186186
})
187187
.map((link) =>
188188
link.submenu ? (
189-
<div key={link.text} className="flex flex-col">
190-
<div className="block px-3 py-2 font-medium text-slate-700 dark:text-slate-300">
189+
<div key={link.text} className="flex flex-col gap-2">
190+
<div className="block px-3 py-3 font-medium text-slate-700 dark:text-slate-300">
191191
{link.text}
192192
</div>
193193
<div className="ml-4">
@@ -196,7 +196,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
196196
key={i}
197197
href={sub.href || '/'}
198198
className={cn(
199-
'block w-full px-4 py-2 text-left text-sm text-slate-700 transition duration-150 ease-in-out first:rounded-t-md last:rounded-b-md hover:bg-slate-100 hover:text-slate-900 dark:text-slate-300 dark:hover:bg-slate-700 dark:hover:text-white',
199+
'block w-full px-4 py-3 text-left text-sm text-slate-700 transition duration-150 ease-in-out first:rounded-t-md last:rounded-b-md hover:bg-slate-100 hover:text-slate-900 dark:text-slate-300 dark:hover:bg-slate-700 dark:hover:text-white',
200200
pathname === sub.href &&
201201
'bg-blue-50 font-medium text-blue-600 dark:bg-blue-900/20 dark:text-blue-200'
202202
)}
@@ -212,7 +212,7 @@ export default function Header({ isGitHubAuthEnabled }: { readonly isGitHubAuthE
212212
key={link.text}
213213
href={link.href || '/'}
214214
className={cn(
215-
'navlink block px-3 py-2 text-slate-700 hover:text-slate-800 dark:text-slate-300 dark:hover:text-slate-200',
215+
'navlink block px-3 py-2 text-slate-700 transition duration-150 ease-in-out hover:bg-slate-100 hover:text-slate-900 dark:text-slate-300 dark:hover:bg-slate-700 dark:hover:text-white',
216216
pathname === link.href && 'font-bold text-blue-800 dark:text-white'
217217
)}
218218
onClick={toggleMobileMenu}

0 commit comments

Comments
 (0)