Skip to content

Commit 2b8f151

Browse files
committed
remove unnecessary checks
1 parent 5632d3d commit 2b8f151

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

contracts/tokenbridge/libraries/vault/MasterVault.sol

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,7 @@ contract MasterVault is Initializable, ERC4626Upgradeable, OwnableUpgradeable {
193193
if (totalProfits > 0) {
194194
IERC4626 _subVault = subVault;
195195
if (address(_subVault) != address(0)) {
196-
uint256 sharesRedeemed = _subVault.withdraw(totalProfits, address(this), address(this));
197-
if (sharesRedeemed == 0) revert NoSharesRedeemed();
196+
_subVault.withdraw(totalProfits, address(this), address(this));
198197
}
199198
IERC20(asset()).safeTransfer(beneficiary, totalProfits);
200199
}
@@ -272,8 +271,7 @@ contract MasterVault is Initializable, ERC4626Upgradeable, OwnableUpgradeable {
272271
totalPrincipal += assets;
273272
IERC4626 _subVault = subVault;
274273
if (address(_subVault) != address(0)) {
275-
uint256 subShares = _subVault.deposit(assets, address(this));
276-
if (subShares == 0) revert NoSubvaultShares();
274+
_subVault.deposit(assets, address(this));
277275
}
278276
}
279277

@@ -291,8 +289,7 @@ contract MasterVault is Initializable, ERC4626Upgradeable, OwnableUpgradeable {
291289

292290
IERC4626 _subVault = subVault;
293291
if (address(_subVault) != address(0)) {
294-
uint256 sharesBurned = _subVault.withdraw(assets, address(this), address(this));
295-
if (sharesBurned == 0) revert NoSharesBurned();
292+
_subVault.withdraw(assets, address(this), address(this));
296293
}
297294

298295
super._withdraw(caller, receiver, _owner, assets, shares);

0 commit comments

Comments
 (0)