Merge pull request #157 from OneNoteDev/bug/null-check

leakymemory · web-flow · commit 4c5e0561de9c · 2016-10-28T15:44:28.000-07:00
Add a null check for the element.
diff --git a/src/scripts/domParsers/domUtils.ts b/src/scripts/domParsers/domUtils.ts
@@ -944,6 +944,10 @@ export module DomUtils {
 	}
 
 	export function getScrollPercent(elem: Element, asDecimalValue = false) {
+		if (!elem) {
+			return 0;
+		}
+
 		let scrollValue: number = (elem.scrollTop * 1.0) / (elem.scrollHeight - elem.clientHeight);
 
 		// console.warn(elem.scrollTop, elem.scrollHeight, elem.clientHeight, scrollValue);

Original file line number	Diff line number	Diff line change
`@@ -944,6 +944,10 @@ export module DomUtils {`
`944`	`944`	`}`
`945`	`945`
`946`	`946`	`export function getScrollPercent(elem: Element, asDecimalValue = false) {`
	`947`	`+ if (!elem) {`
	`948`	`+ return 0;`
	`949`	`+ }`
	`950`	`+`
`947`	`951`	`let scrollValue: number = (elem.scrollTop * 1.0) / (elem.scrollHeight - elem.clientHeight);`
`948`	`952`
`949`	`953`	`// console.warn(elem.scrollTop, elem.scrollHeight, elem.clientHeight, scrollValue);`