Fix the logic to avoid false positive

leakymemory · leakymemory · commit 68f170898815 · 2016-12-28T10:28:13.000-08:00
diff --git a/src/scripts/extensions/authenticationHelper.ts b/src/scripts/extensions/authenticationHelper.ts
@@ -184,6 +184,6 @@ export class AuthenticationHelper {
 	 */
 	protected isThirdPartyCookiesEnabled(userInfo: UserInfoData): boolean {
 		// Note that we are returning true by default to ensure the N-1 scenario.
-		return userInfo.cookieInRequest ? userInfo.cookieInRequest : true;
+		return userInfo.cookieInRequest !== undefined ? userInfo.cookieInRequest : true;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,6 @@ export class AuthenticationHelper {`
`184`	`184`	`*/`
`185`	`185`	`protected isThirdPartyCookiesEnabled(userInfo: UserInfoData): boolean {`
`186`	`186`	`// Note that we are returning true by default to ensure the N-1 scenario.`
`187`		`- return userInfo.cookieInRequest ? userInfo.cookieInRequest : true;`
	`187`	`+ return userInfo.cookieInRequest !== undefined ? userInfo.cookieInRequest : true;`
`188`	`188`	`}`
`189`	`189`	`}`