-
-
Notifications
You must be signed in to change notification settings - Fork 8
Closed
Description
This is just a ticket to keep track of the changes which PHPCSUtils will need to account for by the time PHPCS 4.0 comes out.
No urgency until there is sight of a release date.
As a principle, the code in PHPCSUtils should work with PHPCS 4.x. External standard shouldn't need to do anything special if they only want to support PHPCS 4.x
If external standards want to continue to support PHPCS 3.x as well a PHPCS34Utils
standard should be added to provide the compatibility layer, where necessary.
To do:
- Work-around/account for the removal of the PHCPS native
T_ARRAY_HINT
andT_RETURN_TYPE
tokens. squizlabs/PHP_CodeSniffer@8cba000 - Closure
use
tokens will be parenthesis owners in PHPCS 4.x
squizlabs/PHP_CodeSniffer@08824f3
This affects at least the following:BCTokens::ParenthesisOpeners()
- The
BCFile::getMethodParameters()
/FunctionDeclarations::getParameters()
methods. - The
BCFile::isReference()
/Operators::isReference()
methods. UseStatements::getType()
Probably won't have any influence/impact on PHPCSUtils. Needs verification:
- Removal of the support for "old-style" (pre PHPCS 3.2.0) ignore comments. squizlabs/PHP_CodeSniffer@86e7465
- Removal of the support for "old style" (pre PHPCS 3.3.0) array properties in rulesets. squizlabs/PHP_CodeSniffer@8b5408c
- Verify that any JS/CSS specific code doesn't start throwing errors now the tokenizers have been removed.
PHPCSUtils does not purposefully support JS/CSS anyway, but the backcompat functions and sister-functions for those in PHPCSUtils may have inherited support based on the PHPCS 2.x/3.x implementation.
squizlabs/PHP_CodeSniffer@ea52e7b
Other notes (no sight yet of what the impact will be, if any):
- PHPCS 4.x will drop support for PHP 5.
- PHPCS 4.x will drop support for installation via PEAR.