Merge pull request #1223 from PHPCSStandards/phpcs-4.0/feature/modernize-use-class-constants-for-constant-arrays-2

Modernize: Util\Help: use constant array in class constant

Author: jrfnl

src/Config.php

@@ -1514,7 +1514,7 @@ public function printShortUsage($return=false)
      */
     public function printPHPCSUsage()
     {
-        $longOptions   = explode(',', Help::DEFAULT_LONG_OPTIONS);
+        $longOptions   = Help::DEFAULT_LONG_OPTIONS;
         $longOptions[] = 'cache';
         $longOptions[] = 'no-cache';
         $longOptions[] = 'report';
@@ -1540,7 +1540,7 @@ public function printPHPCSUsage()
      */
     public function printPHPCBFUsage()
     {
-        $longOptions   = explode(',', Help::DEFAULT_LONG_OPTIONS);
+        $longOptions   = Help::DEFAULT_LONG_OPTIONS;
         $longOptions[] = 'suffix';
         $shortOptions  = Help::DEFAULT_SHORT_OPTIONS;
 

src/Util/Help.php

@@ -34,11 +34,36 @@ final class Help
     /**
      * Long options which are available for both the `phpcs` as well as the `phpcbf` command.
      *
-     * {@internal This should be a constant array, but those aren't supported until PHP 5.6.}
-     *
-     * @var string Comma-separated list of the option names.
+     * @var array<string> List of the option names.
      */
-    public const DEFAULT_LONG_OPTIONS = 'basepath,bootstrap,colors,encoding,error-severity,exclude,extensions,file,file-list,filter,ignore,ignore-annotations,no-colors,parallel,php-ini,report-width,runtime-set,severity,sniffs,standard,stdin-path,tab-width,version,vv,vvv,warning-severity';
+    public const DEFAULT_LONG_OPTIONS = [
+        'basepath',
+        'bootstrap',
+        'colors',
+        'encoding',
+        'error-severity',
+        'exclude',
+        'extensions',
+        'file',
+        'file-list',
+        'filter',
+        'ignore',
+        'ignore-annotations',
+        'no-colors',
+        'parallel',
+        'php-ini',
+        'report-width',
+        'runtime-set',
+        'severity',
+        'sniffs',
+        'standard',
+        'stdin-path',
+        'tab-width',
+        'version',
+        'vv',
+        'vvv',
+        'warning-severity',
+    ];
 
     /**
      * Minimum screen width.

tests/Core/Util/Help/HelpTest.php

@@ -190,7 +190,7 @@ public function testOptionFiltering($longOptions, $shortOptions, $expected)
      */
     public static function dataOptionFiltering()
     {
-        $allLongOptions   = explode(',', Help::DEFAULT_LONG_OPTIONS);
+        $allLongOptions   = Help::DEFAULT_LONG_OPTIONS;
         $allLongOptions[] = 'cache';
         $allLongOptions[] = 'no-cache';
         $allLongOptions[] = 'report';
@@ -248,7 +248,7 @@ public static function dataOptionFiltering()
                 ],
             ],
             'Default options only'                            => [
-                'longOptions'  => explode(',', Help::DEFAULT_LONG_OPTIONS),
+                'longOptions'  => Help::DEFAULT_LONG_OPTIONS,
                 'shortOptions' => Help::DEFAULT_SHORT_OPTIONS,
                 'expected'     => [
                     'Scan targets'           => 8,