Skip to content

Commit 3a644e2

Browse files
author
MargeBot
committed
Merge branch 'MAILWEB-6646-add-missing-modals' into 'main'
Add missing modals in the router label view See merge request web/clients!16932
2 parents a8e86a8 + cf90526 commit 3a644e2

File tree

2 files changed

+35
-20
lines changed

2 files changed

+35
-20
lines changed

applications/mail/src/app/router/RouterLabelContainer.tsx

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import { type SOURCE_ACTION } from 'proton-mail/components/list/useListTelemetry
1212
import useScrollToTop from 'proton-mail/components/list/useScrollToTop';
1313
import { ROUTE_ELEMENT } from 'proton-mail/constants';
1414
import MailboxContainerPlaceholder from 'proton-mail/containers/mailbox/MailboxContainerPlaceholder';
15-
import { usePermanentDelete } from 'proton-mail/hooks/actions/delete/usePermanentDelete';
16-
import { useMarkAs } from 'proton-mail/hooks/actions/markAs/useMarkAs';
1715
import { useMailCommander } from 'proton-mail/hooks/commander/useMailCommander';
1816
import { type ElementsStructure, useGetElementsFromIDs } from 'proton-mail/hooks/mailbox/useElements';
1917
import { useMailboxFocus } from 'proton-mail/hooks/mailbox/useMailboxFocus';
@@ -52,6 +50,13 @@ export const RouterLabelContainer = ({ params, navigation, elementsData, actions
5250
handleCheckOnlyOne,
5351
handleCheckRange,
5452
handleCheckAll,
53+
deleteAllModal,
54+
deleteSelectionModal,
55+
selectAllMarkModal,
56+
moveToSpamModal,
57+
moveSnoozedModal,
58+
moveScheduledModal,
59+
selectAllMoveModal,
5560
} = actions;
5661

5762
const listRef = useRef<HTMLDivElement>(null);
@@ -73,8 +78,6 @@ export const RouterLabelContainer = ({ params, navigation, elementsData, actions
7378
const breakpoints = useActiveBreakpoint();
7479

7580
const [commanderModalProps, showCommander, commanderRender] = useModalState();
76-
const { deleteSelectionModal, deleteAllModal } = usePermanentDelete(labelID);
77-
const { selectAllMarkModal } = useMarkAs();
7881
const welcomeFlag = useWelcomeFlag([labelID, selectedIDs.length]);
7982

8083
const [folders] = useFolders();
@@ -106,13 +109,13 @@ export const RouterLabelContainer = ({ params, navigation, elementsData, actions
106109
moveToFolder,
107110
selectAll,
108111
elementRef,
109-
moveScheduledModal,
110-
moveSnoozedModal,
111-
moveToSpamModal,
112-
deleteSelectionModal: deleteSelectionShortcutModal,
113-
deleteAllModal: deleteAllShortcutModal,
114-
selectAllMoveModal,
115-
selectAllMarkModal: markAllModal,
112+
moveScheduledModal: hotkeyMoveScheduledModal,
113+
moveSnoozedModal: hotkeyMoveSnoozedModal,
114+
moveToSpamModal: hotkeyMoveToSpamModal,
115+
deleteSelectionModal: hotkeyDeleteSelectionShortcutModal,
116+
deleteAllModal: hotkeyDeleteAllShortcutModal,
117+
selectAllMoveModal: hotkeySelectAllMoveModal,
118+
selectAllMarkModal: hotkeyMarkAllModal,
116119
} = useMailboxHotkeys(
117120
{
118121
labelID,
@@ -250,16 +253,20 @@ export const RouterLabelContainer = ({ params, navigation, elementsData, actions
250253
</Switch>
251254
</section>
252255
{commanderRender ? <Commander list={commanderList} {...commanderModalProps} /> : null}
253-
{deleteSelectionModal}
254256
{deleteAllModal}
255-
{deleteSelectionShortcutModal}
256-
{deleteAllShortcutModal}
257-
{moveScheduledModal}
258-
{moveSnoozedModal}
259257
{moveToSpamModal}
258+
{moveSnoozedModal}
259+
{moveScheduledModal}
260260
{selectAllMoveModal}
261261
{selectAllMarkModal}
262-
{markAllModal}
262+
{deleteSelectionModal}
263+
{hotkeyMarkAllModal}
264+
{hotkeyMoveToSpamModal}
265+
{hotkeyMoveSnoozedModal}
266+
{hotkeyMoveScheduledModal}
267+
{hotkeySelectAllMoveModal}
268+
{hotkeyDeleteAllShortcutModal}
269+
{hotkeyDeleteSelectionShortcutModal}
263270
</div>
264271
);
265272
};

applications/mail/src/app/router/hooks/useElementActions.tsx

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,12 @@ export const useElementActions = ({ params, navigation, elementsData }: Params)
4444
const page = useMailSelector((state) => state.elements.page);
4545

4646
const { selectAll, setSelectAll } = useSelectAll({ labelID });
47-
const { handleDelete: permanentDelete } = usePermanentDelete(labelID);
47+
const { handleDelete: permanentDelete, deleteSelectionModal, deleteAllModal } = usePermanentDelete(labelID);
4848

49-
const { markAs } = useMarkAs();
49+
const { markAs, selectAllMarkModal } = useMarkAs();
5050
const getElementsFromIDs = useGetElementsFromIDs();
51-
const { moveToFolder } = useMoveToFolder();
51+
const { moveToFolder, moveToSpamModal, moveSnoozedModal, moveScheduledModal, selectAllMoveModal } =
52+
useMoveToFolder();
5253
const onCompose = useOnCompose();
5354

5455
const [folders] = useFolders();
@@ -184,5 +185,12 @@ export const useElementActions = ({ params, navigation, elementsData }: Params)
184185
handleCheckRange,
185186
onMessageLoad,
186187
onMessageReady,
188+
deleteSelectionModal,
189+
deleteAllModal,
190+
selectAllMarkModal,
191+
moveToSpamModal,
192+
moveSnoozedModal,
193+
moveScheduledModal,
194+
selectAllMoveModal,
187195
};
188196
};

0 commit comments

Comments
 (0)