Merge branch 'followup-signature-icon-sdk' into 'main'

Ignore check of anonymous for signatureIssues

See merge request web/clients!19037

Author: MargeBot

applications/drive/src/app/modals/DetailsModal/useFileDetailsModalState.tsx

@@ -127,7 +127,7 @@ export const useFileDetailsModalState = ({ volumeId, linkId, ...modalProps }: Us
             }
         };
         void withLoading(fetchFileDetails());
-    }, [volumeId, linkId, drive]);
+    }, [volumeId, linkId, drive, withLoading, handleError]);
 
     return {
         ...modalProps,

applications/drive/src/app/sections/sharedWith/loaders/useSharedWithMeNodesLoader.ts

@@ -9,7 +9,6 @@ import { splitNodeUid, useDrive } from '@proton/drive/index';
 import useVolumesState from '../../../store/_volumes/useVolumesState';
 import { EnrichedError } from '../../../utils/errorHandling/EnrichedError';
 import { useSdkErrorHandler } from '../../../utils/errorHandling/useSdkErrorHandler';
-import { getIsAnonymousUser } from '../../../utils/sdk/getIsAnonymousUser';
 import { getNodeEntity } from '../../../utils/sdk/getNodeEntity';
 import { getSignatureIssues } from '../../../utils/sdk/getSignatureIssues';
 import { ItemType, useSharedWithMeListingStore } from '../../../zustand/sections/sharedWithMeListing.store';
@@ -43,7 +42,6 @@ export const useSharedWithMeNodesLoader = () => {
                     try {
                         const { node } = getNodeEntity(sharedWithMeMaybeNode);
                         const signatureResult = getSignatureIssues(sharedWithMeMaybeNode);
-                        const isAnonymousUser = getIsAnonymousUser(sharedWithMeMaybeNode);
                         if (!node.deprecatedShareId) {
                             handleError(
                                 new EnrichedError('The shared with me node entity is missing deprecatedShareId', {
@@ -95,7 +93,7 @@ export const useSharedWithMeNodesLoader = () => {
                                         ? node.membership.sharedBy.value
                                         : node.membership.sharedBy.error.claimedAuthor) || '',
                             },
-                            haveSignatureIssues: !isAnonymousUser && !signatureResult.ok,
+                            haveSignatureIssues: !signatureResult.ok,
                             shareId: node.deprecatedShareId,
                         });
                     } catch (e) {

applications/drive/src/app/sections/sharedby/loaders/useSharedByMeNodesLoader.ts

@@ -7,7 +7,6 @@ import { useDrive } from '@proton/drive';
 
 import { EnrichedError } from '../../../utils/errorHandling/EnrichedError';
 import { useSdkErrorHandler } from '../../../utils/errorHandling/useSdkErrorHandler';
-import { getIsAnonymousUser } from '../../../utils/sdk/getIsAnonymousUser';
 import { getNodeEntity } from '../../../utils/sdk/getNodeEntity';
 import { getNodeLocation } from '../../../utils/sdk/getNodeLocation';
 import { getSignatureIssues } from '../../../utils/sdk/getSignatureIssues';
@@ -34,7 +33,6 @@ export const useSharedByMeNodesLoader = () => {
                     try {
                         const { node } = getNodeEntity(sharedByMeMaybeNode);
                         const signatureResult = getSignatureIssues(sharedByMeMaybeNode);
-                        const isAnonymousUser = getIsAnonymousUser(sharedByMeMaybeNode);
                         if (!node.deprecatedShareId) {
                             handleError(
                                 new EnrichedError('The shared with me node entity is missing deprecatedShareId', {
@@ -82,7 +80,7 @@ export const useSharedByMeNodesLoader = () => {
                             mediaType: node.mediaType,
                             thumbnailId: node.activeRevision?.uid || node.uid,
                             shareId: node.deprecatedShareId,
-                            haveSignatureIssues: !isAnonymousUser && !signatureResult.ok,
+                            haveSignatureIssues: !signatureResult.ok,
                         });
                     } catch (e) {
                         handleError(e, {

applications/drive/src/app/sections/sharedby/useSharedByMe.store.ts

@@ -8,7 +8,6 @@ import { getActionEventManager } from '../../utils/ActionEventManager/ActionEven
 import { ActionEventName } from '../../utils/ActionEventManager/ActionEventManagerTypes';
 import { EnrichedError } from '../../utils/errorHandling/EnrichedError';
 import { handleSdkError } from '../../utils/errorHandling/useSdkErrorHandler';
-import { getIsAnonymousUser } from '../../utils/sdk/getIsAnonymousUser';
 import { getNodeEntity } from '../../utils/sdk/getNodeEntity';
 import { getNodeLocation } from '../../utils/sdk/getNodeLocation';
 import { getSignatureIssues } from '../../utils/sdk/getSignatureIssues';
@@ -202,7 +201,6 @@ export const useSharedByMeStore = create<SharedByMeStore>()(
                             if (item.isShared && !getSharedByMeItem(item.uid)) {
                                 const sharedByMeMaybeNode = await drive.getNode(item.uid);
                                 const signatureResult = getSignatureIssues(sharedByMeMaybeNode);
-                                const isAnonymousUser = getIsAnonymousUser(sharedByMeMaybeNode);
                                 const { node } = getNodeEntity(sharedByMeMaybeNode);
                                 if (!node.deprecatedShareId) {
                                     handleSdkError(
@@ -237,7 +235,7 @@ export const useSharedByMeStore = create<SharedByMeStore>()(
                                           }
                                         : undefined,
                                     shareId: node.deprecatedShareId,
-                                    haveSignatureIssues: !isAnonymousUser && !signatureResult.ok,
+                                    haveSignatureIssues: !signatureResult.ok,
                                 });
                             }
                         } catch (error) {
@@ -255,7 +253,6 @@ export const useSharedByMeStore = create<SharedByMeStore>()(
                             } else if (item.isTrashed) {
                                 const sharedByMeMaybeNode = await drive.getNode(item.uid);
                                 const signatureResult = getSignatureIssues(sharedByMeMaybeNode);
-                                const isAnonymousUser = getIsAnonymousUser(sharedByMeMaybeNode);
                                 const { node } = getNodeEntity(sharedByMeMaybeNode);
                                 if (!node.deprecatedShareId) {
                                     handleSdkError(
@@ -290,7 +287,7 @@ export const useSharedByMeStore = create<SharedByMeStore>()(
                                           }
                                         : undefined,
                                     shareId: node.deprecatedShareId,
-                                    haveSignatureIssues: !isAnonymousUser && !signatureResult.ok,
+                                    haveSignatureIssues: !signatureResult.ok,
                                 });
                             }
                         } catch (error) {