remove duplicate tests (#24)

In some cases `new_cmds == legacy_cmds`. This made it more verbose to write and additionally resulted in duplicate tests.

After this PR, if no `legacy_cmds` is passed to `Config`, the value of `new_cmds` is used. Plus, duplicate configs are filtered out.

Author: pmeier

tests/test_plugin.py

@@ -77,7 +77,6 @@ def test_standard_collection(collect_tests, file, cmds, selection):
 @make_parametrization(
     Config(
         new_cmds=("-k", "cpu"),
-        legacy_cmds=("-k", "cpu"),
         selection=(
             "::TestFooCPU::test_bar_cpu",
             "::TestFooCPU::test_baz_cpu",
@@ -88,7 +87,6 @@ def test_standard_collection(collect_tests, file, cmds, selection):
     ),
     Config(
         new_cmds=("-k", "meta"),
-        legacy_cmds=("-k", "meta"),
         selection=(
             "::TestFooMETA::test_bar_meta",
             "::TestFooMETA::test_baz_meta",
@@ -106,15 +104,13 @@ def test_devices(collect_tests, file, cmds, selection):
 @make_parametrization(
     Config(
         new_cmds=("-k", "float16"),
-        legacy_cmds=("-k", "float16"),
         selection=(
             "::TestFooCPU::test_bar_cpu_float16",
             "::TestFooCPU::test_bar_cpu_float16",
         ),
     ),
     Config(
         new_cmds=("-k", "int32"),
-        legacy_cmds=("-k", "int32"),
         selection=(
             "::TestFooCPU::test_bar_cpu_int32",
             "::TestFooCPU::test_bar_cpu_int32",
@@ -130,15 +126,13 @@ def test_dtypes(collect_tests, file, cmds, selection):
 @make_parametrization(
     Config(
         new_cmds=("-k", "add"),
-        legacy_cmds=("-k", "add"),
         selection=(
             "::TestFooCPU::test_bar_add_cpu_float32",
             "::TestFooCPU::test_bar_add_with_alpha_cpu_float32",
         ),
     ),
     Config(
         new_cmds=("-k", "sub"),
-        legacy_cmds=("-k", "sub"),
         selection=(
             "::TestFooCPU::test_bar_sub_cpu_float32",
             "::TestFooCPU::test_bar_sub_with_alpha_cpu_float32",

tests/utils.py

@@ -14,11 +14,13 @@ def __init__(
         *,
         file: Optional[str] = None,
         new_cmds: Union[str, Sequence[str]] = (),
-        legacy_cmds: Union[str, Sequence[str]] = (),
+        legacy_cmds: Optional[Union[str, Sequence[str]]] = None,
         selection: Collection[str],
     ):
         self._file = file
         self._new_cmds = new_cmds
+        if legacy_cmds is None:
+            legacy_cmds = new_cmds
         self._legacy_cmds = legacy_cmds
         self._selection = selection
 
@@ -46,21 +48,25 @@ def make_params(self, file: Optional[str] = None) -> Tuple[ParameterSet, ...]:
         new_cmds = self._parse_cmds(self._new_cmds, file)
         legacy_cmds = self._parse_cmds(self._legacy_cmds, file)
         selection = self._parse_selection(self._selection, file)
-        return (
-            pytest.param(
-                file,
-                new_cmds,
-                selection,
-                id=self._cmds_to_id(new_cmds),
-            ),
-            pytest.param(
-                file,
-                legacy_cmds,
-                selection,
-                id=self._cmds_to_id(legacy_cmds),
-            ),
+
+        new_params = pytest.param(
+            file,
+            new_cmds,
+            selection,
+            id=self._cmds_to_id(new_cmds),
+        )
+        if new_cmds == legacy_cmds:
+            return (new_params,)
+
+        legacy_cmds = pytest.param(
+            file,
+            legacy_cmds,
+            selection,
+            id=self._cmds_to_id(legacy_cmds),
         )
 
+        return (new_params, legacy_cmds)
+
 
 def make_params(*configs: Config, file: Optional[str] = None) -> List[ParameterSet]:
     return [param for config in configs for param in config.make_params(file)]