Skip to content

Commit 026dfb3

Browse files
fix: Remove superfluous warning about superfluous collection members (#104)
1 parent fdd8977 commit 026dfb3

File tree

2 files changed

+0
-17
lines changed

2 files changed

+0
-17
lines changed

dataframely/collection.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -902,13 +902,6 @@ def _validate_input_keys(cls, data: Mapping[str, FrameType], /) -> None:
902902
f"Input misses {len(missing)} required members: {', '.join(missing)}."
903903
)
904904

905-
superfluous = actual - set(cls.members())
906-
if len(superfluous) > 0:
907-
warnings.warn(
908-
f"Input provides {len(superfluous)} superfluous members that are "
909-
f"ignored: {', '.join(superfluous)}."
910-
)
911-
912905

913906
def deserialize_collection(data: str) -> type[Collection]:
914907
"""Deserialize a collection from a JSON string.

tests/collection/test_validate_input.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,3 @@ class MyCollection(dy.Collection):
1919
def test_collection_missing_required_member() -> None:
2020
with pytest.raises(ValueError):
2121
MyCollection.validate({"second": pl.LazyFrame({"a": [1, 2, 3]})})
22-
23-
24-
def test_collection_superfluous_member() -> None:
25-
with pytest.warns(Warning):
26-
MyCollection.validate(
27-
{
28-
"first": pl.LazyFrame({"a": [1, 2, 3]}),
29-
"third": pl.LazyFrame({"a": [1, 2, 3]}),
30-
},
31-
)

0 commit comments

Comments
 (0)