-
Notifications
You must be signed in to change notification settings - Fork 66
add GraphSim module #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add GraphSim module #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new GraphSim module to organize graph state simulation functionality. The change wraps existing graph simulation code in a dedicated module and updates import statements throughout the codebase to use the new module structure.
- Wraps existing graph state functionality in a new
GraphSimmodule - Updates all test files to import from
QuantumClifford.GraphSiminstead ofQuantumClifford - Imports specific functions from the new module into the main
QuantumCliffordnamespace
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/graphs/graphs.jl | Creates the new GraphSim module wrapper with necessary imports |
| src/QuantumClifford.jl | Imports key GraphSim functions into main namespace |
| test/test_graphs_tables.jl | Updates imports to use GraphSim module |
| test/test_graphs_single_qubit_gates.jl | Updates imports to use GraphSim module |
| test/test_graphs_cphase.jl | Updates imports to use GraphSim module |
| test/test_graphs.jl | Updates imports to use GraphSim module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
previously it relies on the side effect that graphs.jl imports Graphs.
c461c36 to
5d4cabd
Compare
|
hmmmm @Krastanov I am not sure how to fix the doctest. Supposedly if it uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the doctests have not finished running, so I am not sure about them.
As for the documentation itself, the failure is in resolving the references. The rules for them are a bit different. Check the various module definitions in docs/make.jl and just add an extra one the way there are a few already for other submodules.
f055ba5 to
63fd922
Compare
- @ref needs to reference to some docstring already rendered in the menu
63fd922 to
1912c8c
Compare
|
@Krastanov I think it's now working:
|
|
@LEXUGE , could you remind me what the status here is? Is this ready for merge after a review or do we have any outstanding questions about it? |
|
It doesn't have anything outstanding pending on me. So should be OK to merge after a review |
|
@Krastanov Would you like to review this PR so I could push forward the graph state measurement and remaining cleanup/documentation. Thanks! |
|
Apologies for the long delay on this. I should be able to review this in the next 7 days. |
No worries. I am also writing up the implementation notes in the mean time. |
Created a new GraphSim module.