feat: use @builder.io/qwik-dom (#161)

Author: manucorporat

package.json

@@ -69,7 +69,7 @@
     "@typescript-eslint/parser": "^4.19.0",
     "concurrently": "^6.2.0",
     "cross-spawn": "^7.0.3",
-    "domino": "^2.1.6",
+    "@builder.io/qwik-dom": "2.1.7",
     "esbuild": "^0.12.13",
     "esbuild-register": "^2.6.0",
     "eslint": "^7.23.0",

scripts/package_build.bzl

@@ -16,7 +16,7 @@ def package_build(
             "@npm//@types/prettier",
             "@npm//@types/source-map-support",
             "@npm//kleur",
-            "@npm//domino",
+            "@npm//@builder.io/qwik-dom",
             "@npm//esbuild",
             "@npm//esbuild-register",
             "@npm//express",

scripts/submodule-core.ts

@@ -81,8 +81,6 @@ async function submoduleCoreProd(config: BuildConfig) {
       ecma: 2018,
       passes: 2,
     },
-    keep_fnames: true,
-    keep_classnames: true,
     format: {
       comments: false,
       preamble: banner.js,

scripts/submodule-optimizer.ts

@@ -98,8 +98,6 @@ export async function submoduleOptimizer(config: BuildConfig) {
               beautify: true,
               indent_level: 2,
             },
-            keep_fnames: true,
-            keep_classnames: true,
             mangle: false,
           });
           await writeFile(p, result.code!);

scripts/submodule-prefetch.ts

@@ -41,8 +41,6 @@ export async function submodulePrefetch(config: BuildConfig) {
       plugins: minifyCode
         ? [
             terser({
-              keep_fnames: true,
-              keep_classnames: true,
               compress: {
                 module: true,
                 keep_fargs: false,
@@ -97,8 +95,6 @@ export async function submodulePrefetch(config: BuildConfig) {
     exports: 'none',
     plugins: [
       terser({
-        keep_fnames: true,
-        keep_classnames: true,
         compress: {
           module: true,
           keep_fargs: false,
@@ -125,8 +121,6 @@ export async function submodulePrefetch(config: BuildConfig) {
     exports: 'none',
     plugins: [
       terser({
-        keep_fnames: true,
-        keep_classnames: true,
         compress: {
           inline: false,
           join_vars: false,

scripts/submodule-qwikloader.ts

@@ -44,8 +44,6 @@ export async function submoduleQwikLoader(config: BuildConfig) {
     outro: `})()`,
     plugins: [
       terser({
-        keep_fnames: true,
-        keep_classnames: true,
         compress: {
           global_defs: {
             'window.BuildEvents': false,
@@ -71,8 +69,6 @@ export async function submoduleQwikLoader(config: BuildConfig) {
     outro: `})()`,
     plugins: [
       terser({
-        keep_fnames: true,
-        keep_classnames: true,
         compress: {
           global_defs: {
             'window.BuildEvents': false,
@@ -102,8 +98,6 @@ export async function submoduleQwikLoader(config: BuildConfig) {
     outro: `})()`,
     plugins: [
       terser({
-        keep_fnames: true,
-        keep_classnames: true,
         compress: {
           global_defs: {
             'window.BuildEvents': true,
@@ -129,8 +123,6 @@ export async function submoduleQwikLoader(config: BuildConfig) {
     outro: `})()`,
     plugins: [
       terser({
-        keep_fnames: true,
-        keep_classnames: true,
         compress: {
           global_defs: {
             'window.BuildEvents': true,

scripts/submodule-server.ts

@@ -24,7 +24,7 @@ import { readPackageJson, writePackageJson } from './package-json';
 export async function submoduleServer(config: BuildConfig) {
   const submodule = 'server';
 
-  const dominoPlugin = await bundleDomino(config);
+  const qwikDomPlugin = await bundleQwikDom(config);
 
   const opts: BuildOptions = {
     entryPoints: [join(config.srcDir, submodule, 'index.ts')],
@@ -33,7 +33,7 @@ export async function submoduleServer(config: BuildConfig) {
     bundle: true,
     target,
     banner,
-    external: [...nodeBuiltIns, 'domino'],
+    external: [...nodeBuiltIns, '@builder.io/qwik-dom'],
     define: {
       ...(await inlineQwikScripts(config)),
       'globalThis.QWIK_VERSION': JSON.stringify(config.distVersion),
@@ -48,7 +48,7 @@ export async function submoduleServer(config: BuildConfig) {
     plugins: [
       importPath(/^@builder\.io\/qwik$/, '../core.mjs'),
       importPath(/^@builder\.io\/qwik\/optimizer$/, '../optimizer.mjs'),
-      dominoPlugin,
+      qwikDomPlugin,
     ],
     watch: watcher(config, submodule),
     inject: [injectGlobalPoly(config)],
@@ -61,7 +61,7 @@ export async function submoduleServer(config: BuildConfig) {
     plugins: [
       importPath(/^@builder\.io\/qwik$/, '../core.cjs'),
       importPath(/^@builder\.io\/qwik\/optimizer$/, '../optimizer.cjs'),
-      dominoPlugin,
+      qwikDomPlugin,
     ],
     watch: watcher(config),
     platform: 'node',
@@ -115,11 +115,11 @@ async function inlineQwikScripts(config: BuildConfig) {
   return define;
 }
 
-async function bundleDomino(config: BuildConfig) {
-  const outfile = join(config.distDir, 'domino.mjs');
+async function bundleQwikDom(config: BuildConfig) {
+  const outfile = join(config.distDir, 'qwikdom.mjs');
 
   const opts: BuildOptions = {
-    entryPoints: [require.resolve('domino')],
+    entryPoints: [require.resolve('@builder.io/qwik-dom')],
     sourcemap: false,
     minify: true,
     bundle: true,
@@ -148,22 +148,22 @@ async function bundleDomino(config: BuildConfig) {
 
   await build(opts);
 
-  const dominoPlugin: Plugin = {
-    name: 'dominoPlugin',
+  const qwikDomPlugin: Plugin = {
+    name: 'domiqwikDomPluginnoPlugin',
     setup(build) {
-      build.onResolve({ filter: /domino/ }, () => {
+      build.onResolve({ filter: /@builder.io\/qwik-dom/ }, () => {
         return {
           path: outfile,
         };
       });
     },
   };
 
-  return dominoPlugin;
+  return qwikDomPlugin;
 }
 
 async function getDominoVersion() {
-  const indexPath = require.resolve('domino');
+  const indexPath = require.resolve('@builder.io/qwik-dom');
   const pkgJsonPath = join(indexPath, '..', '..');
   const pkgJson = await readPackageJson(pkgJsonPath);
   return pkgJson.version;

src/server/api.md

@@ -107,7 +107,7 @@ export function setServerPlatform(document: any, opts: DocumentOptions): Promise
 // @alpha (undocumented)
 export const versions: {
     readonly qwik: string;
-    readonly domino: string;
+    readonly qwikDom: string;
 };
 
 // (No @packageDocumentation comment for this package)

src/server/document.ts

@@ -1,5 +1,5 @@
 import { dehydrate, render } from '@builder.io/qwik';
-import domino from 'domino';
+import qwikDom from '@builder.io/qwik-dom';
 import { setServerPlatform } from './platform';
 import { serializeDocument } from './serialize';
 import type {
@@ -21,7 +21,7 @@ import { createTimer } from './utils';
 export function createGlobal(opts?: GlobalOptions): QwikGlobal {
   opts = opts || {};
 
-  const doc: QwikDocument = domino.createDocument() as any;
+  const doc: QwikDocument = qwikDom.createDocument() as any;
   const baseURI = opts.url === undefined ? BASE_URI : opts.url.href;
   const loc = new URL(baseURI, BASE_URI);
 

src/server/index.ts

@@ -21,5 +21,5 @@ export { setServerPlatform } from './platform';
  */
 export const versions = {
   qwik: (globalThis as any).QWIK_VERSION as string,
-  domino: (globalThis as any).DOMINO_VERSION as string,
+  qwikDom: (globalThis as any).DOMINO_VERSION as string,
 } as const;