Skip to content

Commit 5aaffe5

Browse files
sriram-30sajmera-pensando
authored andcommitted
Regression caused from previous commit
1 parent 044c6b4 commit 5aaffe5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

internal/controllers/upgrademgr.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -151,11 +151,6 @@ func (n *upgradeMgr) HandleUpgrade(ctx context.Context, deviceConfig *amdv1alpha
151151
// 1. Set init status for unprocessed nodes
152152
n.helper.handleInitStatus(ctx, &nodeList.Items[i])
153153

154-
if !n.helper.isNodeReadyForUpgrade(ctx, &nodeList.Items[i]) {
155-
res = ctrl.Result{Requeue: true, RequeueAfter: time.Second * 20}
156-
continue
157-
}
158-
159154
// 2. Handle failed nodes
160155
if n.helper.isNodeStateUpgradeFailed(ctx, &nodeList.Items[i], deviceConfig) {
161156
n.helper.clearUpgradeStartTime(nodeList.Items[i].Name)
@@ -193,6 +188,11 @@ func (n *upgradeMgr) HandleUpgrade(ctx context.Context, deviceConfig *amdv1alpha
193188
continue
194189
}
195190

191+
if !n.helper.isNodeReadyForUpgrade(ctx, &nodeList.Items[i]) {
192+
res = ctrl.Result{Requeue: true, RequeueAfter: time.Second * 20}
193+
continue
194+
}
195+
196196
//This node is a candidate for selection
197197
candidateNodes = append(candidateNodes, nodeList.Items[i])
198198
}

0 commit comments

Comments
 (0)