Merge pull request #21 from RadiusNetworks/update-rubocop-version

Upgrade Rubocop version to 0.62.x

Author: cupakromer

.travis.yml

@@ -1,17 +1,14 @@
-sudo: false
 language: ruby
 cache: bundler
-before_install:
-  - gem update --system
-  - gem install bundler
 bundler_args: --jobs=3 --retry=3 --without documentation debug
 before_script:
   - "bin/ci-code-review"
 script: bin/ci
 rvm:
+  - 2.6
   - 2.5
   - ruby-head
-matrix:
+jobs:
   allow_failures:
     - rvm: ruby-head
   fast_finish: true

CHANGELOG.md

@@ -9,6 +9,7 @@
   `Metrics/BlockLength` checks (Aaron Kromer, #18)
 - Exclude gem specs from block and line length metrics (Aaron Kromer, #20)
 - Standardize on key style of `Layout/AlignHash` (Aaron Kromer, #18)
+- Upgrade to Rubocop 0.62.x (Aaron Kromer, #21)
 
 ### Bug Fixes
 

benchmarks/call_vs_yield.rb

@@ -146,3 +146,36 @@ def pass_through(&block)
           block.call:  3557929.5 i/s - 5.12x  (± 0.14) slower
                    with 95.0% confidence
 ```
+
+### Environment
+
+ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin16]
+GC Disabled: false
+
+### Test Cases
+
+#### Block call vs yield
+
+```
+Warming up --------------------------------------
+          block.call   252.830k i/100ms
+         block yield   266.647k i/100ms
+      block arg only   275.856k i/100ms
+        no arg yield   271.677k i/100ms
+  pass through block   251.117k i/100ms
+Calculating -------------------------------------
+          block.call     11.729M (± 0.9%) i/s -     58.404M in   5.004905s
+         block yield     13.216M (± 0.8%) i/s -     65.862M in   5.007922s
+      block arg only     17.288M (± 0.9%) i/s -     86.067M in   5.009110s
+        no arg yield     16.109M (± 0.9%) i/s -     80.145M in   5.006225s
+  pass through block     10.175M (± 1.0%) i/s -     50.726M in   5.010616s
+                   with 95.0% confidence
+
+Comparison:
+      block arg only: 17287836.2 i/s
+        no arg yield: 16108506.9 i/s - 1.07x  (± 0.01) slower
+         block yield: 13215609.2 i/s - 1.31x  (± 0.02) slower
+          block.call: 11729199.4 i/s - 1.47x  (± 0.02) slower
+  pass through block: 10174648.1 i/s - 1.70x  (± 0.02) slower
+                   with 95.0% confidence
+```

common_rubocop_rails.yml

@@ -222,17 +222,13 @@ Rails/SaveBang:
 #   - http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html
 #   - http://api.rubyonrails.org/classes/ActiveRecord/Relation.html
 #
+# Configuration parameters: Blacklist, Whitelist.
 # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
 Rails/SkipsModelValidations:
-  Blacklist:
-    - 'decrement_counter'
-    - 'increment_counter'
-    - 'toggle!'
-    - 'update_all'
-    - 'update_attribute'
-    - 'update_column'
-    - 'update_columns'
-    - 'update_counters'
+  Whitelist:
+    - 'decrement!'
+    - 'increment!'
+    - 'touch'
 
 # Rails uses compact style by default so we're disabling this with a :hammer:
 # for things likely to be generated by Rails (i.e. most things in app).

radius-spec.gemspec

@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = ">= 2.5"
 
   spec.add_runtime_dependency "rspec", "~> 3.7"
-  spec.add_runtime_dependency "rubocop", "~> 0.59.1"
+  spec.add_runtime_dependency "rubocop", "~> 0.62.0"
 
   spec.add_development_dependency "bundler", "~> 1.16"
   spec.add_development_dependency "rake", "~> 12.0"