Skip to content

Commit 340b7e4

Browse files
jmekkattdtaylor113
authored andcommitted
[OCMUI-3814]Fix flaky osd wizard test case step causes failures in smoke execution (#144)
1 parent 16e99a7 commit 340b7e4

File tree

5 files changed

+5
-14
lines changed

5 files changed

+5
-14
lines changed

cypress/e2e/osd/OsdMarketplaceClusterCreation.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ describe('OSD Marketplace cluster creation tests(OCP-67514)', { tags: ['smoke']
5151

5252
it(`OSD wizard - ${clusterProperties.CloudProvider} ${authType} ${isPscEnabled}-${clusterProperties.Marketplace} : Cluster Settings - Cluster details definitions`, () => {
5353
CreateOSDWizardPage.isClusterDetailsScreen();
54-
cy.get(CreateOSDWizardPage.clusterNameInput).type(clusterProperties.ClusterName);
55-
CreateOSDWizardPage.hideClusterNameValidation();
54+
cy.get(CreateOSDWizardPage.clusterNameInput).type(clusterProperties.ClusterName).blur();
5655
CreateOSDWizardPage.selectRegion(clusterProperties.Region);
5756
if (clusterProperties.hasOwnProperty('Version')) {
5857
CreateOSDWizardPage.selectVersion(clusterProperties.Version);

cypress/e2e/osd/OsdNonCcsClusterCreation.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ describe('OSD Non CCS cluster creation tests(OCP-42746,OCP-21086)', { tags: ['sm
3131

3232
it(`OSD ${clusterPropertiesFile.CloudProvider} wizard - Cluster Settings - Cluster details definitions`, () => {
3333
CreateOSDWizardPage.isClusterDetailsScreen();
34-
cy.get(CreateOSDWizardPage.clusterNameInput).type(clusterPropertiesFile.ClusterName);
35-
CreateOSDWizardPage.hideClusterNameValidation();
34+
cy.get(CreateOSDWizardPage.clusterNameInput).type(clusterPropertiesFile.ClusterName).blur();
3635
CreateOSDWizardPage.singleZoneAvilabilityRadio().should('be.checked');
3736
CreateOSDWizardPage.selectRegion(clusterPropertiesFile.Region);
3837
CreateOSDWizardPage.selectPersistentStorage(clusterPropertiesFile.PersistentStorage);

cypress/e2e/osd/OsdTrialClusterCreation.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ describe(`OSDTrial cluster creation tests(OCP-39415)`, { tags: ['smoke'] }, () =
4343
});
4444
it(`OSD - ${clusterProperties.CloudProvider} wizard - Cluster Settings - Cluster details definitions`, () => {
4545
CreateOSDWizardPage.isClusterDetailsScreen();
46-
cy.get(CreateOSDWizardPage.clusterNameInput).type(clusterProperties.ClusterName);
47-
CreateOSDWizardPage.hideClusterNameValidation();
46+
cy.get(CreateOSDWizardPage.clusterNameInput).type(clusterProperties.ClusterName).blur();
4847
CreateOSDWizardPage.selectRegion(clusterProperties.Region);
4948
CreateOSDWizardPage.singleZoneAvilabilityRadio().check();
5049
CreateOSDWizardPage.multiZoneAvilabilityRadio().check();

cypress/e2e/rosa/RosaClusterGetstartedPage.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ describe('Rosa cluster Get Started page(OCP-56363)', { tags: ['smoke'] }, () =>
196196
RosaGetstartedPage.checkAnchorProperties(
197197
cy.get('a'),
198198
'deploy ROSA clusters with the ROSA CLI',
199-
'https://docs.redhat.com/en/documentation/red_hat_openshift_service_on_aws/4/html/install_rosa_with_hcp_clusters/rosa-hcp-sts-creating-a-cluster-quickly',
199+
'https://docs.redhat.com/en/documentation/red_hat_openshift_service_on_aws/4/html/install_clusters/rosa-hcp-sts-creating-a-cluster-quickly',
200200
true,
201201
);
202202
});
@@ -224,7 +224,7 @@ describe('Rosa cluster Get Started page(OCP-56363)', { tags: ['smoke'] }, () =>
224224
RosaGetstartedPage.checkAnchorProperties(
225225
cy.get('a'),
226226
'deploy a ROSA HCP cluster',
227-
'https://docs.redhat.com/en/documentation/red_hat_openshift_service_on_aws/4/html/install_rosa_with_hcp_clusters/creating-a-rosa-cluster-using-terraform#rosa-hcp-creating-a-cluster-quickly-terraform',
227+
'https://docs.redhat.com/en/documentation/red_hat_openshift_service_on_aws/4/html/install_clusters/creating-a-rosa-cluster-using-terraform',
228228
true,
229229
);
230230
RosaGetstartedPage.checkAnchorProperties(

cypress/pageobjects/CreateOSDWizard.page.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -617,12 +617,6 @@ class CreateOSDCluster extends Page {
617617
cy.get('div').contains(computeNodeType).click();
618618
}
619619

620-
hideClusterNameValidation() {
621-
// Validation popup on cluster name field create flaky situation on below version field.
622-
// To remove the validation popup a click action in cluster left tree required.
623-
this.clusterDetailsTree().click();
624-
}
625-
626620
selectComputeNodeCount(nodeCount) {
627621
this.computeNodeCountSelect().select(`${nodeCount.toString()}`, { force: true });
628622
}

0 commit comments

Comments
 (0)