Skip to content

Commit 4c7defe

Browse files
authored
volto formsupport 3.3.0 compat (#79)
* volto formsupport 3.3.0 compat * test * remove pinned for correct testing purpose
1 parent eb2b992 commit 4c7defe

File tree

5 files changed

+22
-85
lines changed

5 files changed

+22
-85
lines changed

.github/workflows/pyroma.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
2929
# install pyroma
3030
- name: install pyroma
31-
run: pip install pyroma==4.3.0
31+
run: pip install pyroma==4.2
3232

3333
# run pyroma
3434
- name: run pyroma

CHANGES.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ Changelog
44
5.0.17 (unreleased)
55
-------------------
66

7-
- Nothing changed yet.
8-
7+
- formsupport 3.3.0 compatibility.
8+
[mamico]
99

1010
5.0.16 (2025-07-04)
1111
-------------------

setup.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@
2727
"Framework :: Plone :: Addon",
2828
"Framework :: Plone :: 6.0",
2929
"Programming Language :: Python",
30-
"Programming Language :: Python :: 3.7",
31-
"Programming Language :: Python :: 3.8",
32-
"Programming Language :: Python :: 3.10",
30+
"Programming Language :: Python :: 3.11",
3331
"Operating System :: OS Independent",
3432
"License :: OSI Approved :: GNU General Public License v2 (GPLv2)",
3533
],
@@ -56,7 +54,7 @@
5654
"design.plone.contenttypes>=6.0.0.dev0",
5755
"collective.feedback",
5856
"collective.volto.dropdownmenu",
59-
"collective.volto.formsupport[honeypot]>=3.2.0",
57+
"collective.volto.formsupport[honeypot]>=3.2.0,<=3.3.0",
6058
"collective.volto.secondarymenu",
6159
"collective.volto.socialsettings",
6260
"collective.volto.slimheader",

src/design/plone/policy/patches/collective_volto_formsupport.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,23 @@ def reply(self):
106106
"""
107107
This code is a copy of the original reply method from collective.volto.formsupport v3.2.2
108108
"""
109+
if not self.block:
110+
# formsupport 3.3.0 compatibility
111+
from collective.volto.formsupport.interfaces import IPostAdapter
112+
113+
self.form_data_adapter = getMultiAdapter(
114+
(self.context, self.request), IPostAdapter
115+
)
116+
self.form_data = self.get_form_data()
117+
# fix attachment fields
118+
if self.form_data.get("attachments"):
119+
for k, v in self.form_data["attachments"].items():
120+
if "field_id" not in v:
121+
v["field_id"] = k
122+
self.block_id = self.form_data.get("block_id", "")
123+
if self.block_id:
124+
self.block = self.get_block_data(block_id=self.block_id)
125+
109126
store_action = self.block.get("store", False)
110127
send_action = self.block.get("send", [])
111128
self.submit_limit = int(self.block.get("limit", "-1")) # this is the patch

test_plone60.cfg

Lines changed: 0 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -9,81 +9,3 @@ extends =
99
update-versions-file = test_plone60.cfg
1010

1111
[versions]
12-
# to remove when released
13-
collective.volto.formsupport = 3.2.2
14-
15-
# Added by buildout at 2021-12-29 11:05:41.321569
16-
flake8 = 6.0.0
17-
flake8-coding = 1.3.2
18-
flake8-debugger = 4.1.2
19-
flake8-print = 5.0.0
20-
mccabe = 0.7.0
21-
plone.recipe.codeanalysis = 3.0.1
22-
pyflakes = 3.0.1
23-
zpretty = 3.0.1
24-
25-
# Required by:
26-
# flake8-debugger==3.2.1
27-
# flake8-print==3.1.4
28-
pycodestyle = 2.10.0
29-
30-
# Added by buildout at 2023-01-12 09:16:52.328614
31-
bleach = 5.0.1
32-
build = 0.9.0
33-
commonmark = 0.9.1
34-
i18ndude = 5.3.4
35-
keyring = 23.11.0
36-
pep517 = 0.13.0
37-
pkginfo = 1.8.3
38-
readme-renderer = 37.3
39-
requests-toolbelt = 0.10.1
40-
rfc3986 = 2.0.0
41-
rich = 13.3.1
42-
pygments = 2.14.0
43-
twine = 4.0.1
44-
zest.releaser = 7.3.0
45-
46-
# Required by:
47-
# plone.recipe.codeanalysis==3.0.1
48-
check-manifest = 0.48
49-
50-
# Required by:
51-
# zest.releaser==7.2.0
52-
colorama = 0.4.6
53-
54-
# Required by:
55-
# keyring==23.11.0
56-
jaraco.classes = 3.2.3
57-
58-
# Required by:
59-
# jaraco.classes==3.2.3
60-
more-itertools = 9.0.0
61-
62-
# Required by:
63-
# check-manifest==0.48
64-
tomli = 2.0.1
65-
66-
# Required by:
67-
# bleach==5.0.1
68-
webencodings = 0.5.1
69-
70-
dataclasses = 0.8
71-
72-
# Added by buildout at 2023-02-20 14:52:32.917956
73-
backports.functools-lru-cache = 1.6.4
74-
markdown-it-py = 2.1.0
75-
mdurl = 0.1.2
76-
pkgutil-resolve-name = 1.3.10
77-
78-
# Required by:
79-
# PasteDeploy==3.0.1
80-
# plone.restapi==8.33.3
81-
importlib-metadata = 5.2.0
82-
83-
# Added by buildout at 2023-03-01 12:57:48.164146
84-
coverage = 7.0.5
85-
createcoverage = 1.5
86-
87-
# temporary version
88-
collective.taxonomy = 3.1.5
89-
collective.volto.blocksfield = 2.2.0

0 commit comments

Comments
 (0)