Add integration tests for PaywallPresenter #709
Closed
+216
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facumenzella
force-pushed
the
feat/integrationtests
branch
2 times, most recently
from
9730f48 to
316d70e
Compare
facumenzella
force-pushed
the
feat/integrationtests
branch
from
316d70e to
2f1094a
Compare
Closed
tonidero
reviewed
Oct 9, 2025
| public void PaywallOptions_OfferingIdentifierConstructor_SetsOfferingIdentifier() | ||
| { | ||
| const string offeringId = "test_offering"; | ||
| var options = new PaywallOptions(offeringId); |
There was a problem hiding this comment.
I think this is going to change to accept an offering instead of an ID with #710 right?
|
|
||
| namespace RevenueCatUI.Tests | ||
| { | ||
| public class PaywallOptionsAPITests |
There was a problem hiding this comment.
Hmm it's interesting since we don't have tests for the RevenueCat module... are we sure this won't be included in the final bundle? For RevenueCat, we have the API tests live in the IntegrationTests project instead. Maybe we could follow the same approach by making that project also depend on RevenueCatUI and add the tests there?
|
I'll do the same as for RevenueCat in another branch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add APITests for the new RevenueCatUI package