Skip to content

Commit 8693023

Browse files
TofMassilia13320Grom-
authored andcommitted
[services] Fix filler allocation into condition loop
1 parent 044e29d commit 8693023

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

services/stsafea/stsafea_frame_transfer.c

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,13 @@ stse_ReturnCode_t stsafea_frame_receive(stse_Handler_t *pSTSE, stse_frame_t *pFr
182182

183183
/* Append filler frame element even if its length equal 0 */
184184
PLAT_UI8 filler[filler_size];
185-
stse_frame_element_allocate_push(pFrame,
186-
eFiller,
187-
filler_size,
188-
filler);
185+
stse_frame_element_allocate(eFiller,
186+
filler_size,
187+
filler);
188+
if (filler_size > 0) {
189+
stse_frame_push_element(pFrame,
190+
&eFiller);
191+
}
189192

190193
/* ======================================================= */
191194
/* ========= Receive the frame in frame elements ========= */
@@ -301,7 +304,9 @@ stse_ReturnCode_t stsafea_frame_receive(stse_Handler_t *pSTSE, stse_frame_t *pFr
301304
}
302305

303306
/* - Pop Filler element from Frame*/
304-
stse_frame_pop_element(pFrame);
307+
if (filler_size > 0) {
308+
stse_frame_pop_element(pFrame);
309+
}
305310

306311
/* - Verify CRC */
307312
if (computed_crc != *(PLAT_UI16 *)received_crc) {

services/stsafel/stsafel_frame_transfer.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,11 +164,12 @@ stse_ReturnCode_t stsafel_i2c_frame_receive(stse_Handler_t *pSTSE, stse_frame_t
164164

165165
/* Append filler frame element even if its length equal 0 */
166166
PLAT_UI8 filler[filler_size];
167+
stse_frame_element_allocate(eFiller,
168+
filler_size,
169+
filler);
167170
if (filler_size > 0) {
168-
stse_frame_element_allocate_push(pFrame,
169-
eFiller,
170-
filler_size,
171-
filler);
171+
stse_frame_push_element(pFrame,
172+
&eFiller);
172173
}
173174

174175
/* ======================================================= */

0 commit comments

Comments
 (0)