Rename some variables and files (#3)

* Rename some bits

* Remove script from rspack

Author: ocorey-scottlogic

rspack.config.ts

@@ -28,7 +28,6 @@ export default defineConfig({
       "./scripts/graft-studio/header-scroll.js",
       "./scripts/graft-studio/jquery.mmenu.all.js",
       "./scripts/graft-studio/jquery.matchHeight.js",
-      "./scripts/post_counts.ts",
       "applause-button/dist/applause-button.js",
       "cookieconsent/build/cookieconsent.min.js",
     ],

scripts/post_counts.ts renamed to scripts/author-list.ts

@@ -12,6 +12,8 @@ export function loadAuthorList() {
     });
 }
 
+const PAGE_SIZE = 12;
+
 function loadAuthorListForLetter(letter: string) {
   const activeAuthors: Author[] = JSON.parse(
     localStorage.getItem("activeAuthors") ?? "",
@@ -24,36 +26,22 @@ function loadAuthorListForLetter(letter: string) {
   displayCarousel(filteredAuthors);
 }
 
-/*
- * Sort by number of posts descending, then by name
- */
-function compareAuthor(a: Author, b: Author) {
-  if (a.postCount > b.postCount) {
-    return -1;
-  }
-  if (a.postCount < b.postCount) {
-    return 1;
-  }
-  return a.name.localeCompare(b.name);
-}
-
 function displayCarousel(authorList: Author[]) {
   authorList.sort(compareAuthor);
 
-  const pageSize = 12;
-  const pageCount = Math.floor(authorList.length / pageSize);
-  const remainder = authorList.length % pageSize;
+  const pageCount = Math.floor(authorList.length / PAGE_SIZE);
+  const remainder = authorList.length % PAGE_SIZE;
 
   for (let i = 0; i < pageCount; i++) {
-    const start = i * pageSize;
-    const end = (i + 1) * pageSize;
+    const start = i * PAGE_SIZE;
+    const end = (i + 1) * PAGE_SIZE;
 
     const authorsForPage = authorList.slice(start, end);
     displayPage(i, authorsForPage);
   }
 
   if (remainder) {
-    const start = pageCount * pageSize;
+    const start = pageCount * PAGE_SIZE;
     const end = authorList.length;
 
     const authorsForPage = authorList.slice(start, end);
@@ -203,3 +191,16 @@ interface Author {
   postCount: number;
   isActive: boolean;
 }
+
+/*
+ * Sort by number of posts descending, then by name
+ */
+function compareAuthor(a: Author, b: Author) {
+  if (a.postCount > b.postCount) {
+    return -1;
+  }
+  if (a.postCount < b.postCount) {
+    return 1;
+  }
+  return a.name.localeCompare(b.name);
+}

scripts/index.ts

@@ -5,7 +5,7 @@ import jQuery from "jquery";
 import { initialiseMenu } from "./initialise-menu";
 import { loadClapCount } from "./load-clap-count";
 import { makeTimestampsRelative } from "./elapsed";
-import { loadAuthorList } from "./post_counts";
+import { loadAuthorList } from "./author-list";
 
 jQuery(() => {
   initialiseMenu();