Changed success progress indicator ('.') to be red exclamation mark ('!') after an error or failure occurs.

Bilge · Bilge · commit 47ea0c4d94ac · 2017-07-29T19:12:37.000+01:00
diff --git a/src/Printer.php b/src/Printer.php
@@ -57,7 +57,11 @@ protected function onStartTest()
     protected function writeProgress($progress)
     {
         // Record progress so it can be written later instead of at start of line.
-        $this->progress = $this->flawless ? $progress : $this->formatWithColor('fg-red', $progress);
+        $this->progress = !$this->flawless && $progress === '.'
+            // If a previous error or exception occurred, replace '.' with red '!'.
+            ? $this->formatWithColor('fg-red', '!')
+            : $progress
+        ;
 
         ++$this->numTestsRun;
     }
diff --git a/test/functional/success after failure.phpt b/test/functional/success after failure.phpt
@@ -17,8 +17,8 @@ PHPUnit %s
 [31m[0m
 [31m%s%eCapabilitiesTest.php:%i[0m
 [31m[0m
- 75% [31m.[0m [32;1mScriptFUSIONTest\PHPUnitImmediateExceptionPrinter\CapabilitiesTest::testSuccessAfterFailure with data set #2 (true)[0m[32m (%i ms)[0m
-100% [31m.[0m [32;1mScriptFUSIONTest\PHPUnitImmediateExceptionPrinter\CapabilitiesTest::testSuccessAfterFailure with data set #3 (true)[0m[32m (%i ms)[0m
+ 75% [31m![0m [32;1mScriptFUSIONTest\PHPUnitImmediateExceptionPrinter\CapabilitiesTest::testSuccessAfterFailure with data set #2 (true)[0m[32m (%i ms)[0m
+100% [31m![0m [32;1mScriptFUSIONTest\PHPUnitImmediateExceptionPrinter\CapabilitiesTest::testSuccessAfterFailure with data set #3 (true)[0m[32m (%i ms)[0m
 
 
 Time: %s

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,11 @@ protected function onStartTest()`
`57`	`57`	`protected function writeProgress($progress)`
`58`	`58`	`{`
`59`	`59`	`// Record progress so it can be written later instead of at start of line.`
`60`		`- $this->progress = $this->flawless ? $progress : $this->formatWithColor('fg-red', $progress);`
	`60`	`+ $this->progress = !$this->flawless && $progress === '.'`
	`61`	`+ // If a previous error or exception occurred, replace '.' with red '!'.`
	`62`	`+ ? $this->formatWithColor('fg-red', '!')`
	`63`	`+ : $progress`
	`64`	`+ ;`
`61`	`65`
`62`	`66`	`++$this->numTestsRun;`
`63`	`67`	`}`
-Original file line number
+Diff line change
 [31m[0m
 [31m%s%eCapabilitiesTest.php:%i[0m
 [31m[0m
 - 75% [31m.[0m [32;1mScriptFUSIONTest\PHPUnitImmediateExceptionPrinter\CapabilitiesTest::testSuccessAfterFailure with data set #2 (true)[0m[32m (%i ms)[0m
 -100% [31m.[0m [32;1mScriptFUSIONTest\PHPUnitImmediateExceptionPrinter\CapabilitiesTest::testSuccessAfterFailure with data set #3 (true)[0m[32m (%i ms)[0m
 + 75% [31m![0m [32;1mScriptFUSIONTest\PHPUnitImmediateExceptionPrinter\CapabilitiesTest::testSuccessAfterFailure with data set #2 (true)[0m[32m (%i ms)[0m
 +100% [31m![0m [32;1mScriptFUSIONTest\PHPUnitImmediateExceptionPrinter\CapabilitiesTest::testSuccessAfterFailure with data set #3 (true)[0m[32m (%i ms)[0m
 Time: %s