ObjectSpace.{dump,dump_all,dump_shapes} needs vm barrier.

Author: luke-gruber

ext/objspace/objspace_dump.c

@@ -30,6 +30,7 @@
 #include "ruby/io.h"
 #include "vm_callinfo.h"
 #include "vm_core.h"
+#include "vm_sync.h"
 
 RUBY_EXTERN const char ruby_hexdigits[];
 
@@ -776,15 +777,21 @@ static VALUE
 objspace_dump(VALUE os, VALUE obj, VALUE output)
 {
     struct dump_config dc = {0,};
-    if (!RB_SPECIAL_CONST_P(obj)) {
-        dc.cur_page_slot_size = rb_gc_obj_slot_size(obj);
-    }
+    VALUE result = Qnil;
+    RB_VM_LOCKING() {
+        rb_vm_barrier();
+
+        if (!RB_SPECIAL_CONST_P(obj)) {
+            dc.cur_page_slot_size = rb_gc_obj_slot_size(obj);
+        }
 
-    dump_output(&dc, output, Qnil, Qnil, Qnil);
+        dump_output(&dc, output, Qnil, Qnil, Qnil);
 
-    dump_object(obj, &dc);
+        dump_object(obj, &dc);
 
-    return dump_result(&dc);
+        result = dump_result(&dc);
+    }
+    return result;
 }
 
 static void
@@ -840,35 +847,47 @@ static VALUE
 objspace_dump_all(VALUE os, VALUE output, VALUE full, VALUE since, VALUE shapes)
 {
     struct dump_config dc = {0,};
-    dump_output(&dc, output, full, since, shapes);
+    VALUE result = Qnil;
+    RB_VM_LOCKING() {
+        rb_vm_barrier();
 
-    if (!dc.partial_dump || dc.since == 0) {
-        /* dump roots */
-        rb_objspace_reachable_objects_from_root(root_obj_i, &dc);
-        if (dc.roots) dump_append(&dc, "]}\n");
-    }
+        dump_output(&dc, output, full, since, shapes);
 
-    if (RTEST(shapes)) {
-        rb_shape_each_shape_id(shape_id_i, &dc);
-    }
+        if (!dc.partial_dump || dc.since == 0) {
+            /* dump roots */
+            rb_objspace_reachable_objects_from_root(root_obj_i, &dc);
+            if (dc.roots) dump_append(&dc, "]}\n");
+        }
+
+        if (RTEST(shapes)) {
+            rb_shape_each_shape_id(shape_id_i, &dc);
+        }
 
-    /* dump all objects */
-    rb_objspace_each_objects(heap_i, &dc);
+        /* dump all objects */
+        rb_objspace_each_objects(heap_i, &dc);
 
-    return dump_result(&dc);
+        result = dump_result(&dc);
+    }
+    return result;
 }
 
 /* :nodoc: */
 static VALUE
 objspace_dump_shapes(VALUE os, VALUE output, VALUE shapes)
 {
     struct dump_config dc = {0,};
-    dump_output(&dc, output, Qfalse, Qnil, shapes);
+    VALUE result = Qnil;
+    RB_VM_LOCKING() {
+        rb_vm_barrier();
+
+        dump_output(&dc, output, Qfalse, Qnil, shapes);
 
-    if (RTEST(shapes)) {
-        rb_shape_each_shape_id(shape_id_i, &dc);
+        if (RTEST(shapes)) {
+            rb_shape_each_shape_id(shape_id_i, &dc);
+        }
+        result = dump_result(&dc);
     }
-    return dump_result(&dc);
+    return result;
 }
 
 void