Skip to content

feat: style editor & snippet user #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

feat: style editor & snippet user #940

wants to merge 11 commits into from

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 21, 2025 •
edited
Loading

Overview

  • Add "Style Editor" groups.
  • Add "Snippet User" group.

Status

Warning

Blocked by #932. We must not add new migrations to add groups (causes bug). #932 gives us a new way.

Related

Changes

  • added groups:
    • "Style Editor (Advanced)"
    • "Style Editor (Basic)"
    • "Snippet User"
  • added supporting utility functions

Testing

  1. Set up a fresh CMS (no previous volumes): 
    make clean
make setup
  2. In the output, after migrations, see log statement:

    Finished creating CMS groups

  3. Open http://localhost:8000/admin/auth/group/.
  4. Log in.
  5. Verify groups exist.
  6. Open "Style Editor" and "Snippet User" groups.
  7. Verify permissions exist.

UI

…

@wesleyboar
fix(gh-931): cms migrate fails
d3002ba
@wesleyboar
test(migrations): add explicit up-to-date dependencies
6f9becd 
Didn't work when I tested on fresh CMS. But seems simpler than before. Every time I tested previosu commit with AI debugging, we agreed "create_permissions" was a bad thing to do. It usurps Django's order of oeprations.
@wesleyboar
fix: should manage groups after migration
138d1ec
@wesleyboar
Merge branch 'fix/gh-931-cms-migrate-fail' of github.com:TACC/Core-CM…
1251871 
…S into fix/gh-931-cms-migrate-fail
@wesleyboar
Merge branch 'main' into fix/gh-931-cms-migrate-fail
764343c
@wesleyboar
Merge branch 'main' into fix/gh-931-cms-migrate-fail
f33990b
@wesleyboar
feat: style editor
f1435a1
@wesleyboar wesleyboar changed the base branch from main to fix/gh-931-cms-migrate-fail April 21, 2025 21:50
@wesleyboar wesleyboar mentioned this pull request Apr 21, 2025
Merged
@wesleyboar wesleyboar changed the title feat: style editor feat: style editor & snippet user Apr 22, 2025
Base automatically changed from fix/gh-931-cms-migrate-fail to main April 25, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wesleyboar