Small performance improvements

Author: Taritsyn

src/MsieJavaScriptEngine/Helpers/ReflectionHelpers.cs

@@ -44,7 +44,29 @@ public static bool IsFullyFledgedMethod(MethodInfo method)
 
 			return isFullyFledged;
 		}
-#if NETSTANDARD
+#if !NETSTANDARD
+
+		public static MethodInfo[] GetFullyFledgedMethods(MethodInfo[] methods)
+		{
+			int methodCount = methods.Length;
+			var fullyFledgedMethods = new MethodInfo[methodCount];
+			int fullyFledgedMethodIndex = 0;
+
+			for (int methodIndex = 0; methodIndex < methodCount; methodIndex++)
+			{
+				MethodInfo method = methods[methodIndex];
+				if (IsFullyFledgedMethod(method))
+				{
+					fullyFledgedMethods[fullyFledgedMethodIndex] = method;
+					fullyFledgedMethodIndex++;
+				}
+			}
+
+			Array.Resize(ref fullyFledgedMethods, fullyFledgedMethodIndex);
+
+			return fullyFledgedMethods;
+		}
+#else
 
 		public static void FixFieldValueType(ref object value, FieldInfo field)
 		{

src/MsieJavaScriptEngine/HostItemBase.cs

@@ -32,11 +32,6 @@ internal abstract class HostItemBase : IReflect
 		/// </summary>
 		private readonly FieldInfo[] _fields;
 
-		/// <summary>
-		/// List of field names
-		/// </summary>
-		private string[] _fieldNames;
-
 		/// <summary>
 		/// List of properties
 		/// </summary>
@@ -71,19 +66,37 @@ protected HostItemBase(Type type, object target, JsEngineMode engineMode, bool i
 
 			BindingFlags defaultBindingFlags = ReflectionHelpers.GetDefaultBindingFlags(instance);
 			FieldInfo[] fields = _type.GetFields(defaultBindingFlags);
-			string[] fieldNames = fields.Length > 0 ? Array.ConvertAll(fields, f => f.Name) : new string[0];
 			PropertyInfo[] properties = _type.GetProperties(defaultBindingFlags);
 			MethodInfo[] methods = _type.GetMethods(defaultBindingFlags);
-			MethodInfo[] fullyFledgedMethods = methods.Length > 0 ?
-				Array.FindAll(methods, ReflectionHelpers.IsFullyFledgedMethod) : methods;
+			if (methods.Length > 0 && properties.Length > 0)
+			{
+				methods = ReflectionHelpers.GetFullyFledgedMethods(methods);
+			}
 
 			_fields = fields;
-			_fieldNames = fieldNames;
 			_properties = properties;
-			_methods = fullyFledgedMethods;
+			_methods = methods;
 		}
 
 
+		private bool IsField(string name)
+		{
+			bool isField = false;
+			FieldInfo[] fields = _fields;
+			int fieldCount = fields.Length;
+
+			for (int fieldIndex = 0; fieldIndex < fieldCount; fieldIndex++)
+			{
+				if (fields[fieldIndex].Name.Equals(name, StringComparison.Ordinal))
+				{
+					isField = true;
+					break;
+				}
+			}
+
+			return isField;
+		}
+
 		protected abstract object InnerInvokeMember(string name, BindingFlags invokeAttr, Binder binder, object target,
 			object[] args, ParameterModifier[] modifiers, CultureInfo culture, string[] namedParameters);
 
@@ -94,7 +107,7 @@ protected object InvokeStandardMember(string name, BindingFlags invokeAttr, Bind
 			if ((processedInvokeAttr.HasFlag(BindingFlags.GetProperty)
 				|| processedInvokeAttr.HasFlag(BindingFlags.SetProperty)
 				|| processedInvokeAttr.HasFlag(BindingFlags.PutDispProperty))
-				&& Array.IndexOf(_fieldNames, name) != -1)
+				&& IsField(name))
 			{
 				if (processedInvokeAttr.HasFlag(BindingFlags.GetProperty))
 				{