Skip to content

Commit eeec3c4

Browse files
committed
Fixed a error #18 “Block finalizer solved?”
1 parent 1483561 commit eeec3c4

File tree

4 files changed

+14
-18
lines changed

4 files changed

+14
-18
lines changed

NuGet/MsieJavaScriptEngine.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<requireLicenseAcceptance>false</requireLicenseAcceptance>
1313
<description>This library is a .NET wrapper for working with the JavaScript engines of Internet Explorer and Edge (JsRT versions of Chakra, ActiveScript version of Chakra and Classic JavaScript Engine). Project was based on the code of SassAndCoffee.JavaScript (http://github.com/paulcbetts/SassAndCoffee), Chakra Sample Hosts (http://github.com/panopticoncentral/chakra-host) and jsrt-dotnet (http://github.com/robpaveza/jsrt-dotnet).</description>
1414
<summary>This library is a .NET wrapper for working with the JavaScript engines of Internet Explorer and Edge (JsRT versions of Chakra, ActiveScript version of Chakra and Classic JavaScript Engine).</summary>
15-
<releaseNotes>Fixed a minor errors.</releaseNotes>
15+
<releaseNotes>Fixed a error #18 “Block finalizer solved?”.</releaseNotes>
1616
<copyright>Copyright (c) 2012-2018 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
1717
<language>en-US</language>
1818
<tags>JavaScript ECMAScript MSIE IE Edge Chakra</tags>

NuGet/readme.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
=============
2222
RELEASE NOTES
2323
=============
24-
Fixed a minor errors.
24+
Fixed a error #18 “Block finalizer solved?”.
2525

2626
============
2727
PROJECT SITE

src/MsieJavaScriptEngine/JsRt/Edge/ChakraEdgeJsRtJsEngine.cs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1211,17 +1211,15 @@ protected override void Dispose(bool disposing)
12111211
{
12121212
if (_dispatcher != null)
12131213
{
1214-
_dispatcher.Invoke(() =>
1215-
{
1216-
if (_jsContext.IsValid)
1217-
{
1218-
_jsContext.Release();
1219-
}
1220-
_jsRuntime.Dispose();
1221-
});
12221214
_dispatcher.Dispose();
12231215
}
12241216

1217+
if (_jsContext.IsValid)
1218+
{
1219+
_jsContext.Release();
1220+
}
1221+
_jsRuntime.Dispose();
1222+
12251223
base.Dispose(disposing);
12261224
#if NETSTANDARD1_3
12271225

src/MsieJavaScriptEngine/JsRt/Ie/ChakraIeJsRtJsEngine.cs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,17 +1249,15 @@ protected override void Dispose(bool disposing)
12491249
{
12501250
if (_dispatcher != null)
12511251
{
1252-
_dispatcher.Invoke(() =>
1253-
{
1254-
if (_jsContext.IsValid)
1255-
{
1256-
_jsContext.Release();
1257-
}
1258-
_jsRuntime.Dispose();
1259-
});
12601252
_dispatcher.Dispose();
12611253
}
12621254

1255+
if (_jsContext.IsValid)
1256+
{
1257+
_jsContext.Release();
1258+
}
1259+
_jsRuntime.Dispose();
1260+
12631261
base.Dispose(disposing);
12641262
#if NETSTANDARD1_3
12651263

0 commit comments

Comments
 (0)