[#20273] Improve further error handling. Attempt fix obsolete mappings

Author: koubaalo

src/jobs/remove_obsolete_mappings_job.ts

@@ -106,6 +106,7 @@ export class RemoveObsoleteMappingsJob extends SyncJob {
                     // service object is missing, it is ok to delete the mapping
                     operationOk = true;
                 } else {
+                    operationOk &&= ex.response.ok;
                     if (syncedService.errors.length > 0) {
                         this._jobLog.errors.push(syncedService.errors[syncedService.errors.length - 1]);
                     }

src/synced_services/redmine/redmine_synced_service.ts

@@ -858,18 +858,21 @@ export class RedmineSyncedService implements SyncedService {
     } else if (ex.response) {
       const message = `${extraContext.functionName} failed with a response code ${ex.response.statusCode}`;
       error.specification += " - " + message;
-      extraContext.responseErrors = ex.response.body?.errors ?? [];
+      extraContext.responseErrors = !ex.response.body?.errors ? [ex.message] : ex.response.body.errors;
+      extraContext.responseErrors.push(ex.response.statusCode)
       error.data = extraContext;
 
       this._sentryService.logRedmineError(this._projectsUri, message, context);
     } else {
       const message = `${extraContext.functionName} failed without a response`;
       error.specification += " - " + message;
+      extraContext.responseErrors = [ex.message];
       error.data = extraContext;
 
       this._sentryService.logRedmineError(this._projectsUri, message, context);
     }
 
+
     this.errors.push(error);
   }
 

src/synced_services/toggl/toggl_synced_service.ts

@@ -670,13 +670,15 @@ export class TogglTrackSyncedService implements SyncedService {
       const message = `${extraContext.functionName} failed with a response code ${ex.response.statusCode}`;
       error.specification += " - " + message;
       error.data = extraContext;
-      error.data.responseErrors = !ex.response.text ? [] : [ex.response.text];
+      error.data.responseErrors = !ex.response.text ? [ex.response.statusCode] : [ex.response.text, ex.response.statusCode];
 
       this._sentryService.logTogglError(message, context);
     } else {
       const message = `${extraContext.functionName} failed without a response`;
       error.specification += " - " + message;
+      extraContext.responseErrors = [ex.message];
       error.data = extraContext;
+
       this._sentryService.logTogglError(message, context);
     }