remove virtual_environment_mode field_validator

Author: newtonapple

sqlmesh/core/model/meta.py

@@ -332,11 +332,11 @@ def ignored_rules_validator(cls, vs: t.Any) -> t.Any:
 
     @field_validator("grants_target_layer", mode="before")
     def _grants_target_layer_validator(cls, v: t.Any) -> t.Any:
-        return cls._validate_str_enum_value(v)
-
-    @field_validator("virtual_environment_mode", mode="before")
-    def _virtual_environment_mode_validator(cls, v: t.Any) -> t.Any:
-        return cls._validate_str_enum_value(v)
+        if isinstance(v, exp.Identifier):
+            return v.this
+        if isinstance(v, exp.Literal) and v.is_string:
+            return v.this
+        return v
 
     @field_validator("session_properties_", mode="before")
     def session_properties_validator(cls, v: t.Any, info: ValidationInfo) -> t.Any:

tests/core/test_model.py

@@ -1953,7 +1953,6 @@ def test_render_definition_with_grants():
                 'insert' = ['admin'],
                 'roles/bigquery.dataViewer' = ['user:[email protected]']
             ),
-            virtual_environment_mode dev_only,
             grants_target_layer all,
         );
         SELECT 1 as id
@@ -2024,30 +2023,6 @@ def test_render_definition_with_grants():
     default_model = load_sql_based_model(default_expressions)
     assert default_model.grants_target_layer == GrantsTargetLayer.ALL  # default value
 
-    # Test round-trip: parse model with grants_target_layer, render definition, parse back
-    original_expressions = d.parse(
-        """
-        MODEL (
-            name test.roundtrip_model,
-            kind FULL,
-            grants (
-                'select' = ['user1', 'user2'],
-                'insert' = ['admin']
-            ),
-            grants_target_layer 'virtual'
-        );
-        SELECT 1 as id
-        """
-    )
-    original_model = load_sql_based_model(original_expressions)
-    rendered_def = original_model.render_definition(include_defaults=True)
-    rendered_text = d.format_model_expressions(rendered_def)
-    reparsed_expressions = d.parse(rendered_text)
-    reparsed_model = load_sql_based_model(reparsed_expressions)
-
-    assert reparsed_model.grants_target_layer == GrantsTargetLayer.VIRTUAL
-    assert reparsed_model.grants == original_model.grants
-
 
 def test_render_definition_partitioned_by():
     # no parenthesis in definition, no parenthesis when rendered