Skip to content

Conversation

@penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Sep 25, 2025

Assorted fixes to get the new Turing release to work nicely with DPPL.

Things included in this PR:

  • setleafcontext(model, context) convenience method (closes setleafcontext(::Model, ::AbstractContext) #993)
  • Default initial_params in the default sample call for DynamicPPL models (otherwise AbstractMCMC will insert nothing and it will error)
  • Improved signatures for some context methods

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

Benchmark Report for Commit 6e67ce7

Computer Information

Julia Version 1.11.7
Commit f2b3dbda30a (2025-09-08 12:10 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

┌───────────────────────┬───────┬─────────────┬───────────────────┬────────┬────────────────┬─────────────────┐
│                 Model │   Dim │  AD Backend │           VarInfo │ Linked │ t(eval)/t(ref) │ t(grad)/t(eval) │
├───────────────────────┼───────┼─────────────┼───────────────────┼────────┼────────────────┼─────────────────┤
│ Simple assume observe │     1 │ forwarddiff │             typed │  false │            8.9 │             1.5 │
│           Smorgasbord │   201 │ forwarddiff │             typed │  false │          666.0 │            42.3 │
│           Smorgasbord │   201 │ forwarddiff │ simple_namedtuple │   true │          431.1 │            52.0 │
│           Smorgasbord │   201 │ forwarddiff │           untyped │   true │         1158.9 │            31.7 │
│           Smorgasbord │   201 │ forwarddiff │       simple_dict │   true │         6930.4 │            26.4 │
│           Smorgasbord │   201 │ reversediff │             typed │   true │         1044.5 │            40.9 │
│           Smorgasbord │   201 │    mooncake │             typed │   true │         1030.0 │             4.7 │
│    Loop univariate 1k │  1000 │    mooncake │             typed │   true │         6013.0 │             4.3 │
│       Multivariate 1k │  1000 │    mooncake │             typed │   true │         1021.1 │             9.4 │
│   Loop univariate 10k │ 10000 │    mooncake │             typed │   true │        66962.1 │             3.9 │
│      Multivariate 10k │ 10000 │    mooncake │             typed │   true │         8823.8 │            10.5 │
│               Dynamic │    10 │    mooncake │             typed │   true │          150.3 │            10.6 │
│              Submodel │     1 │    mooncake │             typed │   true │           13.1 │             4.9 │
│                   LDA │    12 │ reversediff │             typed │   true │         1049.5 │             2.1 │
└───────────────────────┴───────┴─────────────┴───────────────────┴────────┴────────────────┴─────────────────┘

@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.39%. Comparing base (11d0b69) to head (fb669a1).
⚠️ Report is 1 commits behind head on breaking.

Files with missing lines Patch % Lines
src/sampler.jl 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           breaking    #1057      +/-   ##
============================================
- Coverage     82.43%   82.39%   -0.04%     
============================================
  Files            42       42              
  Lines          3815     3818       +3     
============================================
+ Hits           3145     3146       +1     
- Misses          670      672       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm penelopeysm requested a review from mhauru September 29, 2025 13:12
@yebai
Copy link
Member

yebai commented Sep 30, 2025

One minor comment I have is that we can warn the user if they pass initial_parameters instead of initial_params? I find this a bit confusing since some most other keyword arguments don't use abbrevation, and when initial_parameters is passed, it got a silent expected behaviour.

@github-actions
Copy link
Contributor

DynamicPPL.jl documentation for PR #1057 is available at:
https://TuringLang.github.io/DynamicPPL.jl/previews/PR1057/

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@penelopeysm penelopeysm merged commit 08212a2 into breaking Sep 30, 2025
20 of 21 checks passed
@penelopeysm penelopeysm deleted the py/turing-fixes branch September 30, 2025 14:16
penelopeysm added a commit that referenced this pull request Oct 21, 2025
* Bump minor version

* bump benchmarks compat

* add a skeletal changelog

* `InitContext`, part 3 - Introduce `InitContext` (#981)

* Implement InitContext

* Fix loading order of modules; move `prefix(::Model)` to model.jl

* Add tests for InitContext behaviour

* inline `rand(::Distributions.Uniform)`

Note that, apart from being simpler code, Distributions.Uniform also
doesn't allow the lower and upper bounds to be exactly equal (but we
might like to keep that option open in DynamicPPL, e.g. if the user
wants to initialise all values to the same value in linked space).

* Document

* Add a test to check that `init!!` doesn't change linking

* Fix `push!` for VarNamedVector

This should have been changed in #940, but slipped through as the file
wasn't listed as one of the changed files.

* Add some line breaks

Co-authored-by: Markus Hauru <[email protected]>

* Add the option of no fallback for ParamsInit

* Improve docstrings

* typo

* `p.default` -> `p.fallback`

* Rename `{Prior,Uniform,Params}Init` -> `InitFrom{Prior,Uniform,Params}`

---------

Co-authored-by: Markus Hauru <[email protected]>

* use `varname_leaves` from AbstractPPL instead (#1030)

* use `varname_leaves` from AbstractPPL instead

* add changelog entry

* fix import

* tidy occurrences of varname_leaves as well (#1031)

* `InitContext`, part 4 - Use `init!!` to replace `evaluate_and_sample!!`, `predict`, `returned`, and `initialize_values` (#984)

* Replace `evaluate_and_sample!!` -> `init!!`

* Use `ParamsInit` for `predict`; remove `setval_and_resample!` and friends

* Use `init!!` for initialisation

* Paper over the `Sampling->Init` context stack (pending removal of SamplingContext)

* Remove SamplingContext from JETExt to avoid triggering `Sampling->Init` pathway

* Remove `predict` on vector of VarInfo

* Fix some tests

* Remove duplicated test

* Simplify context testing

* Rename FooInit -> InitFromFoo

* Fix JETExt

* Fix JETExt properly

* Fix tests

* Improve comments

* Remove duplicated tests

* Docstring improvements

Co-authored-by: Markus Hauru <[email protected]>

* Concretise `chain_sample_to_varname_dict` using chain value type

* Clarify testset name

* Re-add comment that shouldn't have vanished

* Fix stale Requires dep

* Fix default_varinfo/initialisation for odd models

* Add comment to src/sampler.jl

Co-authored-by: Markus Hauru <[email protected]>

---------

Co-authored-by: Markus Hauru <[email protected]>

* `InitContext`, part 5 - Remove `SamplingContext`, `SampleFrom{Prior,Uniform}`, `{tilde_,}assume` (#985)

* Remove `SamplingContext` for good

* Remove `tilde_assume` as well

* Split up tilde_observe!! for Distribution / Submodel

* Tidy up tilde-pipeline methods and docstrings

* Fix tests

* fix ambiguity

* Add changelog

* Update HISTORY.md

Co-authored-by: Markus Hauru <[email protected]>

---------

Co-authored-by: Markus Hauru <[email protected]>

* fix missing import

* Shuffle context code around and remove dead code (#1050)

* Delete the `"del"` flag (#1058)

* Delete del

* Fix a typo

* Add HISTORY entry about del

* Fixes for Turing 0.41 (#1057)

* setleafcontext(model, ctx) and various other fixes

* fix a bug

* Add warning for `initial_parameters=...`

* Remove `resume_from` and `default_chain_type` (#1061)

* Remove resume_from

* Format

* Fix test

* remove initial_params warning

* Allow more flexible `initial_params` (#1064)

* Enable NamedTuple/Dict initialisation

* Add more tests

* fix include_all kwarg for predict, improve perf (#1068)

* Fix `include_all` for predict

* Fix include_all for predict, some perf improvements

* Replace `Metadata.flags` with `Metadata.trans` (#1060)

* Replace Medata.flags with Metadata.trans

* Fix a bug

* Fix a typo

* Fix two bugs

* Rename trans to is_transformed

* Rename islinked to is_transformed, remove duplication

* Change pointwise_logdensities default key type to VarName (#1071)

* Change pointwise_logdensities default key type to VarName

* Fix a doctest

* Fix DynamicPPL / MCMCChains methods (#1076)

* Reimplement pointwise_logdensities (almost completely)

* Move logjoint, logprior, ... as well

* Fix imports, etc

* Remove tests that are failing (yes I learnt this from Claude)

* Changelog

* logpdf

* fix docstrings

* allow dict output

* changelog

* fix some comments

* fix tests

* Fix more imports

* Remove stray n

Co-authored-by: Markus Hauru <[email protected]>

* Expand `logprior`, `loglikelihood`, and `logjoint` docstrings

---------

Co-authored-by: Markus Hauru <[email protected]>

* Remove `Sampler` and its interface (#1037)

* Remove `Sampler` and `initialstep`

* Actually just remove the entire file

* forgot one function

* Move sampling test utils to Turing as well

* Update changelog to correctly reflect changes

* [skip ci] Make changelog headings more consistent

---------

Co-authored-by: Markus Hauru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setleafcontext(::Model, ::AbstractContext)

3 participants