fix(runValidation): Throw error if manifest path is not absolute

Author: dimovpetar

src/tools/run_manifest_validation/runValidation.ts

@@ -7,6 +7,7 @@ import {InvalidInputError} from "../../utils.js";
 import {getManifestSchema} from "../../utils/ui5Manifest.js";
 import {Mutex} from "async-mutex";
 import {fileURLToPath} from "url";
+import {isAbsolute} from "path";
 
 const log = getLogger("tools:run_manifest_validation:runValidation");
 const schemaCache = new Map<string, AnySchemaObject>();
@@ -80,6 +81,10 @@ async function readManifest(path: string) {
 	let content: string;
 	let json: object;
 
+	if (!isAbsolute(path)) {
+		throw new InvalidInputError(`The manifest path must be absolute: '${path}'`);
+	}
+
 	try {
 		content = await readFile(path, "utf-8");
 	} catch (error) {

src/tools/run_manifest_validation/schema.ts

@@ -2,7 +2,7 @@ import {z} from "zod";
 
 export const inputSchema = {
 	manifestPath: z.string()
-		.describe("Path to the manifest file to validate."),
+		.describe("Absolute path to the manifest file to validate."),
 };
 
 export const outputSchema = {

test/lib/tools/run_manifest_validation/runValidation.ts

@@ -2,6 +2,7 @@ import anyTest, {TestFn} from "ava";
 import * as sinon from "sinon";
 import esmock from "esmock";
 import {readFile} from "fs/promises";
+import {InvalidInputError} from "../../../../src/utils.js";
 
 const test = anyTest as TestFn<{
 	sinon: sinon.SinonSandbox;
@@ -136,17 +137,27 @@ test("runValidation successfully validates invalid manifest", async (t) => {
 	});
 });
 
+test("runValidation throws error when manifest file path is not absolute", async (t) => {
+	const {runValidation} = t.context;
+
+	await t.throwsAsync(async () => {
+		return await runValidation("relativeManifest.json");
+	}, {
+		instanceOf: InvalidInputError,
+		message: "The manifest path must be absolute: 'relativeManifest.json'",
+	});
+});
+
 test("runValidation throws error when manifest file path is not correct", async (t) => {
 	const {runValidation, readFileStub} = t.context;
 
 	// Stub the readFile function to throw an error
 	readFileStub.rejects(new Error("File not found"));
 
 	await t.throwsAsync(async () => {
-		const result = await runValidation("/nonexistent/path");
-		return result;
+		return await runValidation("/nonexistent/path");
 	}, {
-		instanceOf: Error,
+		instanceOf: InvalidInputError,
 		message: /Failed to read manifest file at .+: .+/,
 	});
 });
@@ -157,10 +168,9 @@ test("runValidation throws error when manifest file content is invalid JSON", as
 	t.context.manifestFileContent = "Invalid JSON Content";
 
 	await t.throwsAsync(async () => {
-		const result = await runValidation("/path/to/manifest.json");
-		return result;
+		return await runValidation("/path/to/manifest.json");
 	}, {
-		instanceOf: Error,
+		instanceOf: InvalidInputError,
 		message: /Failed to parse manifest file at .+ as JSON: .+/,
 	});
 });
@@ -172,8 +182,7 @@ test("runValidation throws error when schema validation function cannot be compi
 	getManifestSchemaStub.resolves(null); // Simulate invalid schema
 
 	await t.throwsAsync(async () => {
-		const result = await runValidation("/path/to/manifest.json");
-		return result;
+		return await runValidation("/path/to/manifest.json");
 	}, {
 		instanceOf: Error,
 		message: /Failed to create UI5 manifest validate function: .+/,
@@ -247,8 +256,7 @@ test("runValidation throws error when external schema cannot be fetched", async
 		.rejects(new Error("Failed to fetch external schema"));
 
 	await t.throwsAsync(async () => {
-		const result = await runValidation("/path/to/manifest.json");
-		return result;
+		return await runValidation("/path/to/manifest.json");
 	}, {
 		instanceOf: Error,
 		message: /Failed to create UI5 manifest validate function: .+/,