feat: upgrade the implementation of vWBNB and check facets

Author: chechu

simulations/vip-545/bscmainnet.ts

@@ -30,6 +30,22 @@ import VBEP20_DELEGATOR_ABI from "./abi/VBep20Delegator.json";
 const { bscmainnet } = NETWORK_ADDRESSES;
 const CHAINLINK_WBNB_FEED = "0x0567F2323251f0Aab15c8dFb1967E4e8A7D42aeE";
 
+const OLD_REWARD_FACET = "0xc2F6bDCEa4907E8CB7480d3d315bc01c125fb63C";
+const OLD_SETTER_FACET = "0x9D1fdD581Bd6E638A7b98ac5567248A0c4E88f64";
+const OLD_MARKET_FACET = "0x94573965fbCCAC5cD4558208A8cCB3F18E71B7Db";
+const OLD_POLICY_FACET = "0x5bb2Dfe996629E558Cd5BDBfC4c0eC7367BB96E9";
+
+const NEW_REWARD_FACET = "0x05e4C8f3dbb6c2eaD4eB1f28611FA7180e79f428";
+const NEW_SETTER_FACET = "0x92B26cb819335DA336f59480F0ca30F9a3f18E0a";
+const NEW_MARKET_FACET = "0xd47c074c219E6947BB350D9aD220eE20fCCC6549";
+const NEW_POLICY_FACET = "0xF2095BeCa3030D43976ED46D5ca488D58354E8c9";
+
+let marketFacetFunctionSelectors: string[];
+let policyFacetFunctionSelectors: string[];
+let rewardFacetFuntionSelectors: string[];
+let setterFacetFuntionSelectors: string[];
+let unitroller: Contract;
+
 forking(60902107, async () => {
   before(async () => {
     await setMaxStalePeriodInChainlinkOracle(
@@ -40,13 +56,55 @@ forking(60902107, async () => {
       315360000,
     );
     await setMaxStalePeriodInBinanceOracle(bscmainnet.BINANCE_ORACLE, "BNB");
+    unitroller = new ethers.Contract(bscmainnet.UNITROLLER, DIAMOND_ABI, ethers.provider);
   });
 
   testVip("vip-543", await vip543());
   testVip("vip-544", await vip544());
   const defaultProxyAdmin = await ethers.provider.getSigner(DEFAULT_PROXY_ADMIN);
 
   describe("Pre-VIP behavior", async () => {
+    before(async () => {
+      rewardFacetFuntionSelectors = await unitroller.facetFunctionSelectors(OLD_REWARD_FACET);
+      setterFacetFuntionSelectors = await unitroller.facetFunctionSelectors(OLD_SETTER_FACET);
+      marketFacetFunctionSelectors = await unitroller.facetFunctionSelectors(OLD_MARKET_FACET);
+      policyFacetFunctionSelectors = await unitroller.facetFunctionSelectors(OLD_POLICY_FACET);
+    });
+
+    describe("facets", async () => {
+      it("market facet function selectors should be correct", async () => {
+        expect(await unitroller.facetFunctionSelectors(OLD_MARKET_FACET)).to.deep.equal(marketFacetFunctionSelectors);
+        expect(await unitroller.facetFunctionSelectors(NEW_MARKET_FACET)).to.deep.equal([]);
+      });
+
+      it("policy facet function selectors should be correct", async () => {
+        expect(await unitroller.facetFunctionSelectors(OLD_POLICY_FACET)).to.deep.equal(policyFacetFunctionSelectors);
+        expect(await unitroller.facetFunctionSelectors(NEW_POLICY_FACET)).to.deep.equal([]);
+      });
+
+      it("setter facet function selectors should be correct", async () => {
+        expect(await unitroller.facetFunctionSelectors(OLD_SETTER_FACET)).to.deep.equal(setterFacetFuntionSelectors);
+        expect(await unitroller.facetFunctionSelectors(NEW_SETTER_FACET)).to.deep.equal([]);
+      });
+
+      it("reward facet function selectors should be correct", async () => {
+        expect(await unitroller.facetFunctionSelectors(OLD_REWARD_FACET)).to.deep.equal(rewardFacetFuntionSelectors);
+        expect(await unitroller.facetFunctionSelectors(NEW_REWARD_FACET)).to.deep.equal([]);
+      });
+
+      it("unitroller should contain only old facet addresses", async () => {
+        expect(await unitroller.facetAddresses()).to.include(OLD_SETTER_FACET);
+        expect(await unitroller.facetAddresses()).to.include(OLD_POLICY_FACET);
+        expect(await unitroller.facetAddresses()).to.include(OLD_MARKET_FACET);
+        expect(await unitroller.facetAddresses()).to.include(OLD_REWARD_FACET);
+
+        expect(await unitroller.facetAddresses()).to.not.include(NEW_SETTER_FACET);
+        expect(await unitroller.facetAddresses()).to.not.include(NEW_POLICY_FACET);
+        expect(await unitroller.facetAddresses()).to.not.include(NEW_MARKET_FACET);
+        expect(await unitroller.facetAddresses()).to.not.include(NEW_REWARD_FACET);
+      });
+    });
+
     describe("check implementation", async () => {
       it("check vBNBAdmin implementation", async () => {
         const vBNBAdmin = (await ethers.getContractAt(TRANSPARENT_PROXY_ABI, vBNB_ADMIN)) as Contract;
@@ -86,11 +144,45 @@ forking(60902107, async () => {
   testVip("VIP-545", await vip545(), {
     callbackAfterExecution: async txResponse => {
       await expectEvents(txResponse, [DIAMOND_ABI], ["DiamondCut"], [1]);
-      await expectEvents(txResponse, [UNITROLLER_ABI], ["NewImplementation"], [40]);
+      await expectEvents(txResponse, [UNITROLLER_ABI], ["NewImplementation"], [41]);
     },
   });
 
   describe("Post-VIP behavior", async () => {
+    describe("facets", async () => {
+      it("market facet function selectors should be updated for new facet address", async () => {
+        const expectSelectors = [...marketFacetFunctionSelectors].sort();
+        const updatedSelectors = [...(await unitroller.facetFunctionSelectors(NEW_MARKET_FACET))].sort();
+
+        expect(updatedSelectors).to.deep.equal(expectSelectors);
+        expect(await unitroller.facetFunctionSelectors(OLD_MARKET_FACET)).to.deep.equal([]);
+      });
+
+      it("policy facet function selectors should be updated for new facet address", async () => {
+        const expectSelectors = [...policyFacetFunctionSelectors].sort();
+        const updatedSelectors = [...(await unitroller.facetFunctionSelectors(NEW_POLICY_FACET))].sort();
+
+        expect(updatedSelectors).to.deep.equal(expectSelectors);
+        expect(await unitroller.facetFunctionSelectors(OLD_POLICY_FACET)).to.deep.equal([]);
+      });
+
+      it("setter facet function selectors should be updated for new facet address", async () => {
+        const expectSelectors = [...setterFacetFuntionSelectors].sort();
+        const updatedSelectors = [...(await unitroller.facetFunctionSelectors(NEW_SETTER_FACET))].sort();
+
+        expect(updatedSelectors).to.deep.equal(expectSelectors);
+        expect(await unitroller.facetFunctionSelectors(OLD_SETTER_FACET)).to.deep.equal([]);
+      });
+
+      it("reward facet function selectors should be updated for new facet address", async () => {
+        const expectSelectors = [...rewardFacetFuntionSelectors].sort();
+        const updatedSelectors = [...(await unitroller.facetFunctionSelectors(NEW_REWARD_FACET))].sort();
+
+        expect(updatedSelectors).to.deep.equal(expectSelectors);
+        expect(await unitroller.facetFunctionSelectors(OLD_REWARD_FACET)).to.deep.equal([]);
+      });
+    });
+
     describe("check implementation", async () => {
       it("check vBNBAdmin implementation", async () => {
         const vBNBAdmin = (await ethers.getContractAt(TRANSPARENT_PROXY_ABI, vBNB_ADMIN)) as Contract;

vips/vip-545/bscmainnet.ts

@@ -54,6 +54,7 @@ export const vTokens = {
   vUSDT: "0xfD5840Cd36d94D7229439859C0112a4185BC0255",
   vUSD1: "0x0C1DA220D301155b87318B90692Da8dc43B67340",
   vWBETH: "0x6CFdEc747f37DAf3b87a35a1D9c8AD3063A1A8A0",
+  vWBNB: "0x6bCa74586218dB34cdB402295796b79663d816e9",
   vXRP: "0xB248a295732e0225acd3337607cc01068e3b9c10",
   vxSolvBTC: "0xd804dE60aFD05EE6B89aab5D152258fD461B07D5",
   vXVS: "0x151B1e2635A717bcDc836ECd6FbB62B674FE3E1D",

vips/vip-545/cut-params-mainnet.json

@@ -16,7 +16,8 @@
         "0xc488847b",
         "0xa78dc775",
         "0x0686dab6",
-        "0xddbf54fd"
+        "0xddbf54fd",
+        "0xc5b4db55"
       ]
     ],
     [
@@ -56,8 +57,7 @@
         "0x7858524d",
         "0xbf32442d",
         "0xededbae6",
-        "0x655f0725",
-        "0xc5b4db55"
+        "0x655f0725"
       ]
     ],
     [