Merge branch 'master' into master

Author: joelhawksley

CHANGELOG.md

@@ -6,6 +6,10 @@
 
     *Ciprian Redinciuc*
 
+* Subclassed components inherit templates from parent.
+
+    *Blake Williams*
+
 * Fix uninitialized constant error from `with_collection` when `eager_load` is disabled.
 
     *Josh Gross*

README.md

@@ -333,6 +333,18 @@ class InlineVariantComponent < ViewComponent::Base
 end
 ```
 
+### Template Inheritance
+
+Components that subclass another component inherit the parent component's
+template if they don't define their own template.
+
+```ruby
+# If `my_link_component.html.erb` is not defined the component will fall back
+# to `LinkComponent`s template
+class MyLinkComponent < LinkComponent
+end
+```
+
 ### Sidecar Assets
 
 ViewComponents supports two options for defining view files.

lib/view_component/base.rb

@@ -183,6 +183,10 @@ def short_identifier
       end
 
       def inherited(child)
+        # Compile so child will inherit compiled `call_*` template methods that
+        # `compile` defines
+        compile
+
         # If we're in Rails, add application url_helpers to the component context
         if defined?(Rails)
           child.include Rails.application.routes.url_helpers unless child < Rails.application.routes.url_helpers

test/app/components/inherited_template_component.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class InheritedTemplateComponent < MyComponent
+end

test/app/components/inherited_with_own_template_component.html.erb

@@ -0,0 +1 @@
+<div>hello, my own template</div>

test/app/components/inherited_with_own_template_component.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class InheritedWithOwnTemplateComponent < MyComponent
+end

test/app/components/inline_inherited_component.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class InheritedInlineComponent < InlineComponent
+end

test/view_component/view_component_test.rb

@@ -645,4 +645,23 @@ def test_renders_component_using_rails_config
 
     assert_text("http://assets.example.com")
   end
+
+  def test_inherited_component_inherits_template
+    render_inline(InheritedTemplateComponent.new)
+
+    assert_selector("div", text: "hello,world!")
+  end
+
+  def test_inherited_component_overrides_inherits_template
+    render_inline(InheritedWithOwnTemplateComponent.new)
+
+    assert_selector("div", text: "hello, my own template")
+  end
+
+  def test_inherited_inline_component_inherits_inline_method
+    render_inline(InheritedInlineComponent.new)
+
+    assert_predicate InheritedInlineComponent, :compiled?
+    assert_selector("input[type='text'][name='name']")
+  end
 end