Skip to content

_cleanup_test_output looks dangerous #81

@yamt

Description

@yamt

_cleanup_test_output uses python glob with recursive=True to find files/directories to remove.
it seems very dangerous as it follows symlinks.
especially when we have a test which tries to create a symlink to "/':

unsafe fn create_symlink_to_root(dir_fd: wasi::Fd) {
// Create a symlink.
wasi::path_symlink("/", dir_fd, "symlink").expect_err("creating a symlink to an absolute path");
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions